New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enterprise css breaks Monaco Editor #2898
Comments
This is a good use case to support #1199 |
Not sure if you solved this or not but i was testing out https://github.com/vanillawc/wc-monaco-editor and if you embed your monaco editor with that it moves the css into the shadow DOM so it seems like with this it wont conflict. We are still resistent to make the breaking change yet. Thinking if that doesnt work to do something here so |
@tmcconechy thank you for this! Actually because of these issues we de-scoped the adoption of Monaco. I will try wc-monaco-editor |
Please give it a shot if it works great, if not i can find a non breaking way to fix the tree so it doesnt conflict. |
@tmcconechy we tried with wc monaco editor and unfortunately the styles are broken anyway I think manually fixing the style conflicts is our only option to make it work for now |
Ok, i thought i saw the issue with the typeahead popupmenu was definately working. Any idea what classes are conflicting here? Should we just test with wc monaco editor then? |
it seems that quick fix could be removing the font-size: 0 but there can be a number of these cases. and override the styles to make it work |
OK yes thats probably easier. It would be tough to remove that font-size right now. What i'll do is do it on the bit of the rework we are starting then. (no reset ect) |
Descoping this for now. But in 5.0 we have encapsulation so it will work in 5.0. For now have to use your current workarounds |
Describe the bug
Using Enteprise css together with Monaco editor causes Monaco editor to not render popups properly due to css conflicts
To Reproduce
Steps to reproduce the behavior:
cd app && yarn install && ng server
.tree a
is conflictingsetTimeout(() => {debugger;}, 3000)
to start a debugger up when its open.Expected behavior
Enterprise css to be encapsulated so that it wouldn't break other libraries
The text was updated successfully, but these errors were encountered: