Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataGrid: 'hideOnOnePage' should keep the page size selector for non-empty state #3706

Closed
hemantg05 opened this issue Apr 3, 2020 · 3 comments · Fixed by #6219
Closed

DataGrid: 'hideOnOnePage' should keep the page size selector for non-empty state #3706

hemantg05 opened this issue Apr 3, 2020 · 3 comments · Fixed by #6219
Assignees
@yohannahbautista
Labels
focus: datagrid Main focus is Datagrid team: Infor PIM Issues for the Infor PIM team type: enhancement ✨ [2] Velocity rating (Fibonacci)
Projects
Enterprise 4.62.x (Mar 2022) Sprint

Comments

@hemantg05
Copy link

hemantg05 commented Apr 3, 2020 •
edited

Description
Soho DataGrid: When user selects number of records per page higher than total items in datagrid, the page selector disappears.

Grid Options:
hidePagerOnOnePage = true

Steps to reproduce the behavior:
Select number of "records per page" higher than total items in datagrid with "hidePagerOnOnePage = true"

Expected behavior
"page size selector" should persist for non empty state. (It should disappear for empty state and it is already working as expected)

Version
enterprise-ng: 6.4.2
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) focus: datagrid Main focus is Datagrid type: enhancement ✨ labels Apr 3, 2020
@tmcconechy tmcconechy changed the title Soho DataGrid: 'hideOnOnePage' should keep the page size selector for non-empty state DataGrid: 'hideOnOnePage' should keep the page size selector for non-empty state Apr 3, 2020
@tmcconechy tmcconechy added the team: Infor PIM Issues for the Infor PIM team label Apr 23, 2020
@tmcconechy
Copy link
Member

Is this still needed or do you have a workaround?

@hemantg05
Copy link
Author

Yes, it is still needed. We can't get back pager and can not modify page size.

@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Feb 15, 2022
@tmcconechy tmcconechy added this to To do in Enterprise 4.62.x (Mar 2022) Sprint via automation Feb 23, 2022
@yohannahbautista yohannahbautista mentioned this issue Mar 23, 2022
Merged
1 task
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.62.x (Mar 2022) Sprint Mar 23, 2022
@ericangeles ericangeles moved this from Pending Review to Ready for QA (beta) in Enterprise 4.62.x (Mar 2022) Sprint Mar 24, 2022
@jbrcna
Copy link
Contributor

jbrcna commented Mar 25, 2022

This has been QA tested and passed on v4.62.0-dev.
https://main-enterprise.demo.design.infor.com/components/datagrid/test-count-in-select-all-current-page-setting.html
image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.62.x (Mar 2022) Sprint Mar 25, 2022
@maezcruz maezcruz mentioned this issue Apr 6, 2022
Closed
@jbrcna jbrcna mentioned this issue Apr 11, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yohannahbautista yohannahbautista

Labels
focus: datagrid Main focus is Datagrid team: Infor PIM Issues for the Infor PIM team type: enhancement ✨ [2] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.62.x (Mar 2022) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3706 - Fix on pagesize selector being hidden infor-design/enterprise
4 participants
@tmcconechy @hemantg05 @jbrcna @yohannahbautista