Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Text color name is undefined in overflow menu #4398

Closed
SofiK opened this issue Sep 21, 2020 · 1 comment · Fixed by #4449
Closed

Editor: Text color name is undefined in overflow menu #4398

SofiK opened this issue Sep 21, 2020 · 1 comment · Fixed by #4449
Assignees
@deep7102
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
Enterprise 4.34.x (Oct 2020) Sprint

Comments

@SofiK
Copy link
Contributor

SofiK commented Sep 21, 2020

Describe the bug
When the editor is so small so that the Text color action is available in the ... overflow menu it's label is "undefined"

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://master-enterprise.demo.design.infor.com/components/editor/example-index.html
  2. make the browser window so small so that the text color button does not fit the toolbar (hint: use device toolbar mode in dev tools)
  3. click the ... menu
  4. See error

Expected behavior
The text color action should have "text color"

Version

  • ids-enterprise: v 4.32.0

Screenshots
image

Platform

  • Infor Application/Team Name: Homepages
  • OS Version: Windows 10
  • Browser Name: Chrome
  • Browser Version: Version 85.0.4183.102 (Official Build) (64-bit)

Additional context
Found in #4296
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 labels Sep 21, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.34.x (Oct 2020) Sprint via automation Sep 21, 2020
@deep7102 deep7102 self-assigned this Sep 28, 2020
@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.34.x (Oct 2020) Sprint Sep 29, 2020
@deep7102 deep7102 mentioned this issue Oct 1, 2020
Merged
1 task
@tmcconechy tmcconechy moved this from In progress to Ready for QA (beta) in Enterprise 4.34.x (Oct 2020) Sprint Oct 5, 2020
@janahintal
Copy link
Contributor

This issue is now resolved. Thank you.
image

@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.34.x (Oct 2020) Sprint Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deep7102 deep7102

Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.34.x (Oct 2020) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4398 - Fix color picker for overflow menu with editor infor-design/enterprise
4 participants
@tmcconechy @SofiK @deep7102 @janahintal