Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favorites: Rename to toggle button #4405

Closed
tmcconechy opened this issue Sep 22, 2020 · 1 comment · Fixed by #4423
Closed

Favorites: Rename to toggle button #4405

tmcconechy opened this issue Sep 22, 2020 · 1 comment · Fixed by #4423
Assignees
@tmcconechy
Labels
design Needs input from IDS Design Team type: bug 🐛 [1] Velocity rating (Fibonacci)
Projects
Enterprise 4.34.x (Oct 2020) Sprint

Comments

@tmcconechy
Copy link
Member

Describe the change

We decided favorites is not a component it should be on the toggle buttons page and classified there.

  • 'Favorites' should have to be renamed to 'Toggle' and folded under the Button list in the Enterprise component list.
  • 'Favorites' page removed from here https://design.infor.com/code/ids-enterprise/latest/favorites and shown as a toggle a button example
  • Anywhere in code where it's called "Favorites" may have to be updated.

Expected behavior
Nothing just renaming/categorizing

Version

  • ids-enterprise: [ v4.32]

Platform

  • All/Chrome

Additional context
https://jira.infor.com/browse/HLPE-299
@tmcconechy tmcconechy self-assigned this Sep 22, 2020
@tmcconechy tmcconechy added [1] Velocity rating (Fibonacci) type: bug 🐛 labels Sep 22, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.34.x (Oct 2020) Sprint via automation Sep 22, 2020
@tmcconechy tmcconechy added the design Needs input from IDS Design Team label Sep 22, 2020
@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.34.x (Oct 2020) Sprint Sep 28, 2020
@tmcconechy tmcconechy mentioned this issue Sep 28, 2020
Merged
1 task
@tmcconechy tmcconechy moved this from In progress to Ready for QA (beta) in Enterprise 4.34.x (Oct 2020) Sprint Sep 29, 2020
@janahintal
Copy link
Contributor

This issue is now resolved. Thank you.
Uploading image.png…

@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.34.x (Oct 2020) Sprint Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmcconechy tmcconechy

Labels
design Needs input from IDS Design Team type: bug 🐛 [1] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.34.x (Oct 2020) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4405 - Moved favorites example infor-design/enterprise
2 participants
@tmcconechy @janahintal