Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal: fullsize responsive issue on Android phones in Landscape mode. #4451

Closed
drinkaj opened this issue Oct 1, 2020 · 5 comments · Fixed by #4902
Closed

Modal: fullsize responsive issue on Android phones in Landscape mode. #4451

drinkaj opened this issue Oct 1, 2020 · 5 comments · Fixed by #4902
Assignees
@ericangeles
Labels
team: landmark For Landmark issues type: bug 🐛 [5] Velocity rating (Fibonacci)
Projects
Enterprise 4.50.x (Mar 2021) Sprint

Comments

@drinkaj
Copy link

drinkaj commented Oct 1, 2020

See an issue on Androids using fullsize 'responsive' on modals when viewing in Landscape mode.

Used the following URL
https://master-enterprise.demo.design.infor.com/components/modal/example-fullsize-responsive.html

Using browser stack in my example.
In portrait mode the modal expands to the screen edges.
In landscape mode the modal doesn't expand to the screen edges.

See screen shots.

Platform

  • Device: Samsung Galaxy S10

landmarkExample
landscape
portrait
landmarkIphoneExample
@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) type: bug 🐛 labels Oct 1, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.35.x (Nov 2020) Sprint via automation Oct 1, 2020
@tmcconechy tmcconechy added the team: landmark For Landmark issues label Oct 28, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.36.x (Dec 2020) Sprint via automation Oct 28, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.50.x (Mar 2021) Sprint via automation Jan 22, 2021
@ericangeles ericangeles self-assigned this Mar 2, 2021
@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.50.x (Mar 2021) Sprint Mar 2, 2021
@ericangeles ericangeles mentioned this issue Mar 2, 2021
Merged
1 task
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.50.x (Mar 2021) Sprint Mar 2, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.50.x (Mar 2021) Sprint Mar 9, 2021
@janahintal
Copy link
Contributor

Working on Mobile devices but not on iPad

Mobile & Samsung Tablet:
image
image

iPad Pro 12.9 2020 Chrome
image

@janahintal janahintal moved this from Ready for QA (beta) to Failed QA (beta) in Enterprise 4.50.x (Mar 2021) Sprint Mar 12, 2021
@tmcconechy
Copy link
Member

tmcconechy commented Mar 12, 2021 •
edited

this was made for iphone configuration. the ipad has too much space so its not really setup for that. Is that right @ericangeles ?

@ericangeles
Copy link
Contributor

@tmcconechy that's correct. Basically, the iPad Pro's screen resolution is about 2048 x 2732 px and has a viewport size of 1024 x 1366 px which is considering as a medium desktop.

@tmcconechy tmcconechy moved this from Failed QA (beta) to Ready for QA (beta) in Enterprise 4.50.x (Mar 2021) Sprint Mar 15, 2021
@tmcconechy
Copy link
Member

Yes thats what i thought. So i think this should be considered done

@janahintal
Copy link
Contributor

Thanks for this. :D Will now move this ticket to Done.

@janahintal janahintal moved this from Ready for QA (master) to Done in Enterprise 4.50.x (Mar 2021) Sprint Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericangeles ericangeles

Labels
team: landmark For Landmark issues type: bug 🐛 [5] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.50.x (Mar 2021) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4451 - Fix fullsize responsive on android phones in landscape mode infor-design/enterprise
4 participants
@tmcconechy @drinkaj @ericangeles @janahintal