Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal/Message: No control of Focus on return from MessageDialog #4507

Closed
nbeare-infor opened this issue Oct 19, 2020 · 2 comments · Fixed by #4509
Closed

Modal/Message: No control of Focus on return from MessageDialog #4507

nbeare-infor opened this issue Oct 19, 2020 · 2 comments · Fixed by #4509
Assignees
Labels
type: bug 🐛 [1] Velocity rating (Fibonacci)

Comments

@nbeare-infor
Copy link

The introduction of the "noRefocus" setting on the Modal component broke our UI. Upon return from display of message dialog, we no longer have control of where the focus is placed.

The noRefocus setting should be added to the Message component also and passed on to the Modal component.
i.e.
noRefocus: false,

added to MESSAGE_DEFAULTS

and
noRefocus: this.settings.noRefocus,

added to
this.message.modal({

@tmcconechy tmcconechy self-assigned this Oct 19, 2020
@tmcconechy tmcconechy added [1] Velocity rating (Fibonacci) type: bug 🐛 labels Oct 19, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.34.x (Oct 2020) Sprint via automation Oct 19, 2020
@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.34.x (Oct 2020) Sprint Oct 19, 2020
@tmcconechy tmcconechy changed the title No control of Focus on return from MessageDialog Modal/Message: No control of Focus on return from MessageDialog Oct 19, 2020
@tmcconechy
Copy link
Member

Whil efixing this i found a not worthy thing. There is actually two settings returnFocus ad noRefocus. `returnFocus did work so if you want to focus something specific and dont want to upgrade you can put that in your app.

These are bit redundant but i wont break the API right now. And note that if you provide returnFocus it will use that and ignore noRefocus even after this fix. So its sort of use one or the other and the returnFocus could work as a workaround.

@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.34.x (Oct 2020) Sprint Oct 19, 2020
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.34.x (Oct 2020) Sprint Oct 22, 2020
@janahintal
Copy link
Contributor

This issue is now resolved. Thank you.
image

image

@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.34.x (Oct 2020) Sprint Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [1] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants