Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataGrid: Click event is not triggered when using key search #4550

Closed
ablomq opened this issue Oct 27, 2020 · 5 comments · Fixed by #4604
Closed

DataGrid: Click event is not triggered when using key search #4550

ablomq opened this issue Oct 27, 2020 · 5 comments · Fixed by #4604
Assignees
Labels
team: m3 Issues for m3 and sub teams type: bug 🐛 [3] Velocity rating (Fibonacci)

Comments

@ablomq
Copy link

ablomq commented Oct 27, 2020

Describe the bug
We have columns marked as hyperlinks that relies on the click event to perform different actions.

A SohoDataGridColumn:

            {
                id: column.name,
                name: column.description,
                field: column.name,
                sortable: true,
                hidden: false,
                formatter: this.getOrderNumberFormatter(m3DialogParams.h5Url),
                click: this.orderNumberCallback(m3DialogParams),           // The callback is not triggered when using key search
            };

But when using key search and the field is marked as found by key search the attached callback function is never called.

Expected behavior
A click event should be triggered so the callback function is called when clicking on a field even when using key search.

Version

  • ids-enterprise-ng: 7.6.0

Screenshots
With no key search the hyperlinks works fine and the click event is triggered when clicking on the order no:
image

But when using key search and the field is marked as found by key search the callback which is attacked to the click event is not triggered when clicking on the order no:
image

@tmcconechy
Copy link
Member

I tried to reproduce this but could not. I think i have the steps right but feel free to correct.

  1. I updated https://master-enterprise.demo.design.infor.com/components/datagrid/example-keyword-search.html to show a console log on the click event of the hyperlink cell (may take a while to update)
  2. go to the keyword search and type "Comp" and hit enter
  3. this highlights
  4. go click on the cells that are highlighted and check the console -> can see the click event is firing

You might want to test a newer version? Or perhaps im missing something in my steps?

@ablomq
Copy link
Author

ablomq commented Oct 27, 2020

I've checked your example. When the keyword search field is empty I can see that all rows works by looking at the console:
image

But if I enter the keyword "Compressor" and hit enter some of the rows that worked previously doesn't work now (nothing is printed in the console when I click on them):
image
I've highlighted those that doesn't work yellow. But for some reason some of them works while others does not.

I also noted that clicking around a row that didn't work previously suddenly works and vice versa.

@tmcconechy tmcconechy transferred this issue from infor-design/enterprise-ng Oct 27, 2020
@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) team: m3 Issues for m3 and sub teams type: bug 🐛 labels Oct 27, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.35.x (Nov 2020) Sprint via automation Oct 27, 2020
@tmcconechy
Copy link
Member

tmcconechy commented Oct 27, 2020

I found that clicking the highlighted part doesnt work.

@janahintal
Copy link
Contributor

QA Failed. There's no console log 'clicked' . Please refer on the images below.

After Clicking the Product Name Column (outside the link) itself. No console log.
image

After Clicking the link itself.
image

@janahintal janahintal moved this from Ready for QA (beta) to Failed QA (beta) in Enterprise 4.35.x (Nov 2020) Sprint Nov 24, 2020
@tmcconechy tmcconechy moved this from Failed QA (beta) to Ready for QA (beta) in Enterprise 4.35.x (Nov 2020) Sprint Nov 24, 2020
@janahintal
Copy link
Contributor

@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.35.x (Nov 2020) Sprint Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: m3 Issues for m3 and sub teams type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants