Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker: shows placeholder and error for non-required fields in some languages #4613

Closed
SofiK opened this issue Nov 17, 2020 · 4 comments · Fixed by #4625
Closed

Datepicker: shows placeholder and error for non-required fields in some languages #4613

SofiK opened this issue Nov 17, 2020 · 4 comments · Fixed by #4625
Assignees
Labels
priority: high team: homepages Issues for the homepages team type: bug 🐛 [3] Velocity rating (Fibonacci)

Comments

@SofiK
Copy link
Contributor

SofiK commented Nov 17, 2020

Describe the bug
Datepickers that are not required shows errors in some languages when emptied.
This issue only happens in some languages; The following which we've found so far: Swedish, Afrikaans (South Africa), Danish (Denmark), Dutch (Netherlands), French (Canada), Hindi (India), Korean (Korea), Lithuanian (Lithuania)
The issue is that if you have an input value in the datepicker and then remove it some formatted error is shown (Even when no date is allowed)

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://design.infor.com/code/ids-enterprise/latest/demo/components/datepicker/example-timeformat?locale=sv-SE
  2. Click on the first datepicker
  3. Pick a date so that the input field shows a value
  4. Mark the text
  5. Delete it
    => Notice that some form of format placeholder is shown
  6. Click outside the datepicket
    => Notice that there are errors showing in the input
  7. Do the same steps for en-US => No placeholder or errors are showing

Expected behavior
There should not be any errors when removing the value from a datepicker that allows no value. Also I haven't seen this error placeholder before.

Version

  • ids-enterprise: 4.34.1

Screenshots
image

Platform

  • Infor Application/Team Name: Homepages
  • OS Version: Windows 1
  • Browser Name: Chrome
  • Browser Version: Version 86.0.4240.183 (Official Build) (64-bit)

Additional context
Add any other context about the problem here.

@SofiK SofiK changed the title Datepicker: Clear date and time in Swedish shows error format Datepicker: shows placeholder and error for non-required fields in some languages Nov 17, 2020
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: demo-app bug 🪲 team: homepages Issues for the homepages team labels Nov 17, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.36.x (Dec 2020) Sprint via automation Nov 17, 2020
@tmcconechy
Copy link
Member

The mask pattern is a configuration you can do to make it have a placeholder. Its an option and not commonly used. My guess is this is just a problem with this examples configuration but will take a look into it if we can next sprint

@SofiK
Copy link
Contributor Author

SofiK commented Nov 17, 2020

Hi Tim!
Yes please take a look at it. We discovered this issue in Homepages after the latest IDS update. And it only happen for some languages. We are not using the mask pattern.

@tmcconechy
Copy link
Member

tmcconechy commented Nov 17, 2020

Seems like something changed between 4.32 and 4.33 where masks with - in the date pattern fail like this

https://4320-enterprise.demo.design.infor.com/components/datepicker/example-timeformat?locale=sv-SE
https://4330-enterprise.demo.design.infor.com/components/datepicker/example-timeformat?locale=sv-SE

Moving this up. Caused by this change most likely https://github.com/infor-design/enterprise/pull/4408/files

@tmcconechy tmcconechy self-assigned this Nov 17, 2020
@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.35.x (Nov 2020) Sprint Nov 17, 2020
@tmcconechy tmcconechy assigned EdwardCoyle and unassigned tmcconechy Nov 17, 2020
@EdwardCoyle EdwardCoyle added type: bug 🐛 [3] Velocity rating (Fibonacci) and removed type: demo-app bug 🪲 [2] Velocity rating (Fibonacci) labels Nov 19, 2020
@EdwardCoyle EdwardCoyle moved this from In progress to Pending Review in Enterprise 4.35.x (Nov 2020) Sprint Nov 19, 2020
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.35.x (Nov 2020) Sprint Nov 24, 2020
@janahintal
Copy link
Contributor

This issue is now resolved.
image

@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.35.x (Nov 2020) Sprint Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high team: homepages Issues for the homepages team type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants