Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header: Searchfield is also triggered when you open the Appmenu #4617

Closed
jbrcna opened this issue Nov 18, 2020 · 6 comments · Fixed by #4644
Closed

Header: Searchfield is also triggered when you open the Appmenu #4617

jbrcna opened this issue Nov 18, 2020 · 6 comments · Fixed by #4644
Assignees
Labels
type: bug 🐛 [3] Velocity rating (Fibonacci)

Comments

@jbrcna
Copy link
Contributor

jbrcna commented Nov 18, 2020

Describe the bug
when the Appmenu is triggered the search field also opens up

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://master-enterprise.demo.design.infor.com/components/header/example-long-title-with-button.html
  2. Click on the hamburger button
  3. Notice that the search field expands
  4. See error.

Expected behavior
Large GIF (1128x526)

Version

  • ids-enterprise: v4.35.0-dev

Screenshots
Large GIF (1128x526)

Platform
all major browsers

Additional context
Add any other context about the problem here.

@tmcconechy
Copy link
Member

This must have started in 4.33 as it works in https://4320-enterprise.demo.design.infor.com/components/header/example-long-title-with-button.html

I think we should try and fix this asap

@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) type: bug 🐛 labels Nov 18, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.35.x (Nov 2020) Sprint via automation Nov 18, 2020
@ericangeles ericangeles self-assigned this Nov 19, 2020
@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.35.x (Nov 2020) Sprint Nov 19, 2020
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.35.x (Nov 2020) Sprint Nov 25, 2020
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.35.x (Nov 2020) Sprint Dec 1, 2020
@jbrcna
Copy link
Contributor Author

jbrcna commented Dec 2, 2020

QA Passed
v4.35.0-dev
https://master-enterprise.demo.design.infor.com/components/header/example-long-title-with-button.html
notice that when you open that app menu the Hamburger icon turns to X. Is this working as expected?
image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.35.x (Nov 2020) Sprint Dec 2, 2020
@tmcconechy
Copy link
Member

tmcconechy commented Dec 2, 2020

@EdwardCoyle I noticed that as well but i didnt say anything. You changed the icon right to a X close icon? Think that works just fine but just checking...

@EdwardCoyle
Copy link
Contributor

@tmcconechy Yeah that was changed in a separate PR: #4646. The (X) behavior is something that's been there but was no longer working

@tmcconechy
Copy link
Member

Sure - i think it works better anyways. But as noted it is a change.

@jbrcna
Copy link
Contributor Author

jbrcna commented Dec 9, 2020

Thank you @tmcconechy and @EdwardCoyle for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants