Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Dirty indicator sticks around (won't reset) when a new line "<br>" is introduced to the editor #4624

Closed
gilbugauisan opened this issue Nov 19, 2020 · 3 comments · Fixed by #4680

Comments

@gilbugauisan
Copy link

Describe the bug
Dirty indicator sticks around (won't reset) when a new line "<br>" is introduced to the editor (after save)

To Reproduce
Steps to reproduce the behavior:
https://master-enterprise.demo.design.infor.com/components/editor/test-dirty-tracking-reset.html

  1. go in the editor and put cursor at the end and press enter a 3/4 times
  2. click "reset dirty"
  3. dirty indicator sticks around

Expected behavior
dirty indicator should reset even with new lines introduced in the editor (use case: after saving the form)

Version

  • ids-enterprise: 4.35.0-dev (dev), 4.31.4 (prod)

Screenshots
N/A

Platform

  • Infor Application/Team Name: Infor GHR/FSM
  • Device: Web/PC
  • OS Version: Windows 10
  • Browser Name: chrome
  • Browser Version: Version 86.0.4240.198 (Official Build) (64-bit)

Additional context
The developer also observed that the dirty indicator is present on load when the content or payload of the editor has new lines "<br>" in it.

@tmcconechy tmcconechy changed the title Dirty indicator sticks around (won't reset) when a new line "<br>" is introduced to the editor Editor: Dirty indicator sticks around (won't reset) when a new line "<br>" is introduced to the editor Nov 19, 2020
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 labels Nov 19, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.36.x (Dec 2020) Sprint via automation Nov 19, 2020
@tmcconechy tmcconechy added the team: landmark For Landmark issues label Dec 9, 2020
@pwpatton
Copy link
Contributor

pwpatton commented Dec 11, 2020

Related Landmark Jira ticket
https://jira.lawson.com/browse/LMCLIENT-31908 - 'Save' action not available on Description after more than two updates

Not exactly sure how the dirty indicator itself related to this. If we had the "Reset Dirty" disabled when the field was not dirty then I could at least see that no "field is dirty" message was being sent when the field changed.

@tmcconechy
Copy link
Member

Please fix in 4.36 and I will patch in 4.35 once merged

@jbrcna
Copy link
Contributor

jbrcna commented Dec 23, 2020

QA Passed
this is now working as expected. thank you
v4.36.0-dev
https://master-enterprise.demo.design.infor.com/components/editor/test-dirty-tracking-reset.html

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.36.x (Dec 2020) Sprint Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high team: landmark For Landmark issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants