Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: Opens on mouse up (drag/highlight from other field and release the mouse click on dropdown) #4638

Closed
marclouisgenedeguzman opened this issue Nov 24, 2020 · 2 comments · Fixed by #4684
Assignees
Labels
team: m3 Issues for m3 and sub teams type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@marclouisgenedeguzman
Copy link

Describe the bug
The dropdown opens when you release the mouse up from dragging or highlighting any items in the view.

To Reproduce
Steps to reproduce the behavior (application implementation):

  1. Go to https://master-enterprise.demo.design.infor.com/components/dropdown/example-no-search.html
  2. highlight the label above the dropdown
  3. release the mouse click inside the dropdown div

dropdown opens on mouseup

Expected behavior
Dropdown should only open on click not from mouse up

Version

  • ids-enterprise-ng 7.2.4

Screenshots
If applicable, add screenshots to help explain your problem.

Platform

  • Infor Application/Team Name: M3 H5 UI Team
  • Device: N/A
  • OS Version: Windows 10
  • Browser Name: Google Chrome
  • Browser Version: Version 85.0.4183.83 (Official Build) (64-bit)

Additional context

@tmcconechy tmcconechy changed the title Dropdown opens on mouse up (drag/highlight from other field and release the mouse click on dropdow) Dropdown: Opens on mouse up (drag/highlight from other field and release the mouse click on dropdown) Nov 24, 2020
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) priority: trival Least important issues team: m3 Issues for m3 and sub teams type: bug 🐛 labels Nov 24, 2020
@tmcconechy
Copy link
Member

I think we can probably change from mouseup to click. However this seems pretty minor. In general we might be using mouseup in other places where click might be better.

Task Here: Try and see if everything works changing the mouseup handler to a click handler.

@tmcconechy tmcconechy added this to To do in Enterprise 4.36.x (Dec 2020) Sprint via automation Nov 24, 2020
@tmcconechy tmcconechy removed the priority: trival Least important issues label Nov 24, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.37.x (Jan 2021) Sprint via automation Dec 1, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.36.x (Dec 2020) Sprint via automation Dec 14, 2020
@tmcconechy tmcconechy self-assigned this Dec 14, 2020
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.36.x (Dec 2020) Sprint Dec 14, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.35.x (Nov 2020) Sprint via automation Dec 21, 2020
@tmcconechy tmcconechy moved this from To do to Patched in Enterprise 4.35.x (Nov 2020) Sprint Dec 21, 2020
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.36.x (Dec 2020) Sprint Dec 22, 2020
@jbrcna
Copy link
Contributor

jbrcna commented Dec 23, 2020

QA Passed
This is working as expected. just to calrify, is this also applicable when closing the list/dropdown menu?
v4.36.0-dev
https://master-enterprise.demo.design.infor.com/components/dropdown/example-no-search.html
https://master-enterprise.demo.design.infor.com/components/dropdown/example-index

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.36.x (Dec 2020) Sprint Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: m3 Issues for m3 and sub teams type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants