Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage (Editable): Widget border color issue in uplift dark theme #4640

Closed
volante007 opened this issue Nov 24, 2020 · 1 comment · Fixed by #4660
Closed

Homepage (Editable): Widget border color issue in uplift dark theme #4640

volante007 opened this issue Nov 24, 2020 · 1 comment · Fixed by #4660
Assignees
Labels
focus: dark mode dark mode team: homepages Issues for the homepages team type: bug 🐛 [1] Velocity rating (Fibonacci)

Comments

@volante007
Copy link

volante007 commented Nov 24, 2020

Describe the bug
The border color for widgets on an editable homepage behaves different in uplift dark theme compared to other themes / colors. After hovering, the border does not change back correctly. Also, if items have been hovered and then edit mode is exited, the border is not reverted.

To Reproduce

  1. Go to https://design.infor.com/code/ids-enterprise/latest/demo/components/homepage/example-editable.html?theme=uplift&variant=dark&colors=0066D4
  2. Notice the correct border around the widgets
  3. Hover a widget, see the blue border (correct, or should perhaps be white?)
  4. Hover out of the widget, see the border become white (incorrect)
  5. Click "Toggle Edit Mode" button to make the Homepage non-editable, see the white border remains (incorrect)

Expected behavior
The hover border color is removed when hovering out of the widget / exiting edit mode.

Version

  • ids-enterprise: v4.34.2

Additional context
Other variants in uplift + all variants in subtle theme seem to look fine. This isn't major, just looks a bit glitchy in dark theme

@tmcconechy tmcconechy added [1] Velocity rating (Fibonacci) team: homepages Issues for the homepages team type: bug 🐛 labels Nov 24, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.36.x (Dec 2020) Sprint via automation Nov 24, 2020
@ericangeles ericangeles self-assigned this Dec 2, 2020
@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.36.x (Dec 2020) Sprint Dec 2, 2020
@tmcconechy tmcconechy moved this from In progress to Ready for QA (beta) in Enterprise 4.36.x (Dec 2020) Sprint Dec 14, 2020
@jbrcna
Copy link
Contributor

jbrcna commented Dec 15, 2020

The issue is now resolved. Thank you

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.36.x (Dec 2020) Sprint Dec 15, 2020
@inforandy inforandy added the focus: dark mode dark mode label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: dark mode dark mode team: homepages Issues for the homepages team type: bug 🐛 [1] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants