Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locale: A large negative number losing a digit #4656

Closed
Sovia opened this issue Dec 2, 2020 · 1 comment · Fixed by #4768
Closed

Locale: A large negative number losing a digit #4656

Sovia opened this issue Dec 2, 2020 · 1 comment · Fixed by #4768
Assignees
@tmcconechy
Labels
priority: high team: landmark For Landmark issues type: bug 🐛 [5] Velocity rating (Fibonacci)
Projects
Enterprise 4.36.x (Dec 2020) Sprint Enterprise 4.37.x (Jan 2021) Sprint

Comments

@Sovia
Copy link
Contributor

Sovia commented Dec 2, 2020

Describe the bug
A large negative number is losing a 0 digit when .formatNumber is called. This is causing the number -922,589,489,099.38 to become -92,258,948,999.38

To Reproduce
Steps to reproduce the behavior:

  1. Unzip test-format-big-negative.zip into the codebase, then navigate to it.
  2. Enter -922589489099.38 into the Numeric Input field
  3. Click the Format button (this will call .formatNumber, and the formatted value to be put in the Formatted Value field.
  4. See error, that the Formatted Value field's value is -92258948999.38

Expected behavior
We shouldn't lose a digit when formatting a negative big decimal.

Version

  • ids-enterprise: v4.36.0-dev

Screenshots
FormatNumberBigDecimalIssue

Platform

  • All
@tmcconechy tmcconechy changed the title Format Number: A large negative number losing a digit Locale: A large negative number losing a digit Dec 2, 2020
@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) team: landmark For Landmark issues type: bug 🐛 labels Dec 2, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.36.x (Dec 2020) Sprint via automation Jan 22, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.37.x (Jan 2021) Sprint via automation Jan 22, 2021
@tmcconechy tmcconechy self-assigned this Jan 22, 2021
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.37.x (Jan 2021) Sprint Jan 22, 2021
@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.36.x (Dec 2020) Sprint Jan 22, 2021
@tmcconechy tmcconechy mentioned this issue Jan 22, 2021
Merged
2 tasks
@tmcconechy tmcconechy moved this from In progress to To Patch in Enterprise 4.36.x (Dec 2020) Sprint Jan 22, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.37.x (Jan 2021) Sprint Jan 25, 2021
@tmcconechy tmcconechy moved this from To Patch to Patched 4.36.2 in Enterprise 4.36.x (Dec 2020) Sprint Jan 25, 2021
@jbrcna
Copy link
Contributor

jbrcna commented Jan 26, 2021

QA Passed
v4.37.0-dev
https://master-enterprise.demo.design.infor.com/components/locale/test-format-big-negative.html

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.37.x (Jan 2021) Sprint Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmcconechy tmcconechy

Labels
priority: high team: landmark For Landmark issues type: bug 🐛 [5] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.36.x (Dec 2020) Sprint
  
Patched 4.36.2
Enterprise 4.37.x (Jan 2021) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4656 - Added a fix for locale losing a digit infor-design/enterprise
3 participants
@tmcconechy @Sovia @jbrcna