Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepages: Add option for smaller sizes tiles/widgets #4663

Closed
jccote-infor opened this issue Dec 3, 2020 · 11 comments · Fixed by #4699
Closed

Homepages: Add option for smaller sizes tiles/widgets #4663

jccote-infor opened this issue Dec 3, 2020 · 11 comments · Fixed by #4699
Assignees
Labels
team: OAD OAD Team Issues and Enhancements type: enhancement ✨ [5] Velocity rating (Fibonacci)

Comments

@jccote-infor
Copy link

jccote-infor commented Dec 3, 2020

Is your feature request related to a problem or use case? Please describe.
We are working a design that contains smaller elements than the current ones in the home page see designs on https://jira.infor.com/browse/STS-90

First attempt to work through homepage provided no means to adjust the tile set's gutter width, leaving large gaps between smaller tiles. These seems to be because its set to 360px widgets.

This is a request to allow the home page to use tiles in a 259px (or as close as possible using the math). Like the designs in the link.

Describe the solution you'd like

  • Add a setting/way in the home page component to do this design and add an example.
  • Change the block grid to have layout animations and use flex or css grid, including animations when adding new tiles

Describe alternatives you've considered

  • Current attempt switches presentation from homepage to the blockgrid control. however this lacks animations
  • Move to flexlayout

Additional context

  • Stratus Team
  • STS-90 in jira

Dev Tasks Summary

@tmcconechy tmcconechy transferred this issue from infor-design/enterprise-ng Dec 3, 2020
@tmcconechy tmcconechy changed the title Open Questions on STS-90 Homepages: Add option for smaller sizes boxes Dec 3, 2020
@tmcconechy tmcconechy changed the title Homepages: Add option for smaller sizes boxes Homepages: Add option for smaller sizes tiles/widgets Dec 3, 2020
@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) team: OAD OAD Team Issues and Enhancements labels Dec 3, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.37.x (Jan 2021) Sprint via automation Dec 3, 2020
@tmcconechy
Copy link
Member

Just discussed this with @deep7102 and we think that it might be the easiest to add animations to the block grid and fix that up (use css grid and flex box now since we dont need IE 9 anymore)

@jccote-infor
Copy link
Author

Determined discussing with Tim that the current approach with blockgrid may be our path. I'll do the light fixes advised in the pull request then put aside for January sprint.

Thanks all, Jerry

@tmcconechy
Copy link
Member

Cool, Yeah that way you can move forward with something. Then we will add the animations.

@tmcconechy
Copy link
Member

Possible solution posted on MS teams by Jan

Just needed to overwrite widget width, min/max-width styles. everything work as expected.

homepageOptions: SohoHomePageOptions = {
  gutterSize: 20,
  widgetWidth: 300,
  widgetHeight: 300,
  animate: true,
  columns: 5,
};
<div soho-homepage [homePageOptions]="homepageOptions">
  <df-add-tile (addTile)="addTile()"></df-add-tile>
  <div soho-widget [removable]="true" class="df-tile">
  </div>
  ....
</div>
.widget.df-tile {
  width: 300px;
  min-height: 300px;
  max-height: 300px;
}

Let me know if that resolves it for you here.

@tmcconechy
Copy link
Member

In addition they would like 6 columns to work. So i think we just need to work in this example and ensure 4,5,6 columns work.

@jccote-infor
Copy link
Author

jccote-infor commented Dec 7, 2020

Determined that existing homepage widget does have an input point for the core constants of tile and gutter size, so we can stick with it instead of blockgrid. Many thanks to Jan Dvorak for the assist. Some adjustments to the core resize function are needed to effect five and six columns in responsive layout - see attachment sts90_resize.txt here
sts90_resize.txt
for a revision that seems to work (limited dev testing so for, more focused testing needed)

Remaining work to be done - the class/LESS revisions within the tile work but the class naming is unclear, will improve on those.

@jccote-infor
Copy link
Author

jccote-infor commented Dec 9, 2020

We're considering setting the widget sizing within IDS Angular. We reduced from 360 or so down to a 259px square, looks like the change would go to _homepage.scss, defs for (.homepage .card, .homepage .widget)

@tmcconechy
Copy link
Member

We can look when we tackle this. The types are there https://github.com/infor-design/enterprise-ng/blob/master/projects/ids-enterprise-typings/lib/homepage/soho-homepage.d.ts#L21

But in order to introduce the css change, i guess we would have to add a "small-widget" size. If we did i dont think the correct size would be 259 but perhaps 260. So basically we would have to add a new class so thats not really an NG thing.

@jccote-infor
Copy link
Author

whatever the number, I might be on the wrong track myself. The value set Jan showed us how to fill in is the driver, perhaps into direct element style settings

@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.36.x (Dec 2020) Sprint Dec 23, 2020
@jccote-infor
Copy link
Author

jccote-infor commented Dec 29, 2020

Stratus Dev is working well with it. The home page tiles are responding well at all column counts up to 6, the most I can get at their new reduced size. This completes the -ng side of JIRA STS-118 (paging on home page) and the still-in-process STS-160 (reduce home page tile size)

Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: OAD OAD Team Issues and Enhancements type: enhancement ✨ [5] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants