Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid: updateRow() drops the 'draggable' attribute on RowReorder Formatter #4674

Closed
vonnyw opened this issue Dec 10, 2020 · 2 comments · Fixed by #4676
Closed

Datagrid: updateRow() drops the 'draggable' attribute on RowReorder Formatter #4674

vonnyw opened this issue Dec 10, 2020 · 2 comments · Fixed by #4676

Comments

@vonnyw
Copy link
Contributor

vonnyw commented Dec 10, 2020

Describe the bug
updateRow() drops the 'draggable' attribute of RowReorder Formatter, therefore the row is no longer draggable.
Additionally, the isHandle attribute is not evaluated appropriately within the arrange component.

To Reproduce
Steps to reproduce the behavior:

  1. Add the following updateRow line to the datagrid-rowreorder.demo.ts:
[ 
 onRowReordered(event: SohoDataGridRowReorderedEvent) {
    console.log('startIndex: ' + event.startIndex, 'endIndex: ' + event.endIndex);
    this.datagrid.updateRow(event.endIndex, this.datagrid.dataset[event.endIndex]);
  }
]

image

image

  1. Go to http://localhost:4200/ids-enterprise-ng-demo/datagrid-rowreorder
  2. Reorder a row
  3. Try to drag the row up or down, it's no longer draggable.

Expected behavior
Drag handler should still work after updateRow is called.

Version

  • ids-enterprise: 4.35

Screenshots
If applicable, add screenshots to help explain your problem.

Platform

  • Infor Application/Team Name: Infor Landmark
  • OS Version: Windows 10
  • Browser Name: Chrome
  • Browser Version: Version 86.0.4240.198 (Official Build) (64-bit)

Additional context
Add any other context about the problem here.

@vonnyw vonnyw added priority: high team: landmark For Landmark issues labels Dec 10, 2020
@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) type: bug 🐛 labels Dec 11, 2020
@tmcconechy tmcconechy changed the title Datagrid-Update row drops the draggable attribute on RowReorder Formatter Datagrid: Update row drops the draggable attribute on RowReorder Formatter Dec 11, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.36.x (Dec 2020) Sprint via automation Dec 11, 2020
@tmcconechy tmcconechy self-assigned this Dec 11, 2020
@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.36.x (Dec 2020) Sprint Dec 11, 2020
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.36.x (Dec 2020) Sprint Dec 11, 2020
@vonnyw vonnyw changed the title Datagrid: Update row drops the draggable attribute on RowReorder Formatter Datagrid: updateRow() drops the 'draggable' attribute on RowReorder Formatter Dec 11, 2020
@tmcconechy
Copy link
Member

Please fix in 4.36 and I will patch in 4.35 once merged

@tmcconechy tmcconechy added this to To do in Enterprise 4.35.x (Nov 2020) Sprint via automation Dec 11, 2020
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.36.x (Dec 2020) Sprint Dec 14, 2020
@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.36.x (Dec 2020) Sprint Dec 15, 2020
@tmcconechy tmcconechy moved this from To do to Patched in Enterprise 4.35.x (Nov 2020) Sprint Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high team: landmark For Landmark issues type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants