Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datagrid: Apply filter is automatically occurring when the user enter a value into a lookup filter column and tabs out #4678

Closed
claudenbach opened this issue Dec 11, 2020 · 5 comments · Fixed by #4679
Closed

Datagrid: Apply filter is automatically occurring when the user enter a value into a lookup filter column and tabs out #4678

claudenbach opened this issue Dec 11, 2020 · 5 comments · Fixed by #4679
Assignees
@tmcconechy
Labels
priority: high team: landmark For Landmark issues type: bug 🐛 [1] Velocity rating (Fibonacci)
Projects
Enterprise 4.36.x (Dec 2020) Sprint Enterprise 4.35.x (Nov 2020) Sprint

Comments

@claudenbach
Copy link
Contributor

Describe the bug
Apply filter is automatically occurring when the user enters a value directly into a lookup filter field and tabs out. The gridOption of filterWhenTyping is set to false.

Steps to reproduce the behavior:

  1. Using the attached test-lookup-automatically-filtering.html
  2. Enter a value into the filter row of the Product Id column
  3. Hit the tab key
  4. Method applyFilter() is called on a change

Expected behavior
Similar to other filter columns, applyFilter is not automatically invoked.

Version
v4.36.0-dev

Landmark will need this fixed in v4.35.x.
@claudenbach
Copy link
Contributor Author

Git-4678.zip

@claudenbach
Copy link
Contributor Author

image

@tmcconechy tmcconechy self-assigned this Dec 11, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.36.x (Dec 2020) Sprint via automation Dec 11, 2020
@tmcconechy
Copy link
Member

Please fix in 4.36 and I will patch in 4.35 once merged (Tim 👍🏻 )

@tmcconechy
Copy link
Member

Looks like the filterWhenTyping setting is not being applied for the lookup filter only

@tmcconechy tmcconechy added the [1] Velocity rating (Fibonacci) label Dec 11, 2020
@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.36.x (Dec 2020) Sprint Dec 11, 2020
@tmcconechy tmcconechy mentioned this issue Dec 11, 2020
Merged
1 task
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.36.x (Dec 2020) Sprint Dec 11, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.35.x (Nov 2020) Sprint via automation Dec 11, 2020
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.36.x (Dec 2020) Sprint Dec 16, 2020
@janahintal
Copy link
Contributor

This issue is now resolved. Thank you.

@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.36.x (Dec 2020) Sprint Dec 17, 2020
@tmcconechy tmcconechy moved this from To do to Patched in Enterprise 4.35.x (Nov 2020) Sprint Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmcconechy tmcconechy

Labels
priority: high team: landmark For Landmark issues type: bug 🐛 [1] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.35.x (Nov 2020) Sprint
  
Patched
Enterprise 4.36.x (Dec 2020) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4678 - Fix filterWhenTyping setting with lookup infor-design/enterprise
3 participants
@tmcconechy @claudenbach @janahintal