Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitter: Search Field is not hidden by the split #4696

Closed
Milan1983 opened this issue Dec 18, 2020 · 5 comments · Fixed by #5797
Closed

Splitter: Search Field is not hidden by the split #4696

Milan1983 opened this issue Dec 18, 2020 · 5 comments · Fixed by #5797
Assignees
Labels
team: appbuilder Issues for the App builder team timebox Timebox this issue to solve quickly or defer to later type: bug 🐛 [3] Velocity rating (Fibonacci)

Comments

@Milan1983
Copy link
Contributor

Milan1983 commented Dec 18, 2020

Describe the bug
When you split does not hidden search field . I am adding this markup to see the problem.

<div class="page-container two-column fixed splitter-container">
  <section class="main">
    <div class="content scrollable">
      <div class="field">
        <label for="searchfield">Search</label>
        <input id="searchfield" name="searchfield" class="searchfield autocomplete" data-options= '{"clearable": "true", "showAllResults": false, "source": "//latest-enterprise.demo.design.infor.com/api/states?term="}' placeholder="Type a search term"/>
      </div>
    </div>
  </section>
  <nav class="sidebar scrollable">
    <div class="content">
      <div id="splitter" class="splitter"></div>
    </div>
  </nav>
</div>
<script>
$('#splitter').splitter({
  attributes: [
    { name: 'id', value: 'splitter-id-1' },
    { name: 'data-automation-id', value: 'splitter-automation-id-1' }
  ]
});
</script>

To Reproduce
Steps to reproduce the behavior:

  1. split to left
  2. will see search icon

Expected behavior
Can not see search icon

Version
4.35.2

Screenshots

image

Platform

  • Infor Application/Team Name: Subsystems
  • OS Version: Windows 10
  • Browser Name: Chrome
  • Browser Version: 87.0.4280.88

Thank you Tim for sent me this markup

@tmcconechy tmcconechy changed the title Search Field is not hidden Splitter: Search Field is not hidden by the split Dec 18, 2020
@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) type: bug 🐛 labels Dec 18, 2020
@tmcconechy
Copy link
Member

From what i saw i think its because the splitter uses flex and so does the search field container. I think the workaround might be to contain the search field in something else that negates the css flex.

Do not what i see is that the searchfield "stops" the splitter from moving and then it has extra scrolling this size of the searchfield on the right of the splitter

@tmcconechy tmcconechy added the timebox Timebox this issue to solve quickly or defer to later label Jun 14, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.54.x (July 2021) Sprint via automation Jun 14, 2021
@ghost ghost removed this from To do in Enterprise 4.54.x (July 2021) Sprint Jun 30, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Sep 23, 2021
@tmcconechy tmcconechy added the team: appbuilder Issues for the App builder team label Sep 29, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.57.x (Oct 2021) Sprint via automation Sep 29, 2021
@ericangeles
Copy link
Contributor

@tmcconechy it looks like this issue has been resolved already.

https://main-enterprise.demo.design.infor.com/components/splitter/example-searchfield.html

@tmcconechy
Copy link
Member

@ericangeles i pushed an example for this. But notice that you cant "push" the search field around. It just stops at the search field. I think maybe it should resize the search field

@nganotice
Copy link

Splitter isn't overlapping w/ the Search Field anymore. I just wanted to confirm if the Search Field wont go back to it's old state when the splitter is already on the leftmost part of the screen.

Video 18

If that's the responsiveness we're achieving, I'll move this ticket to Done.

CC @yohannahbautista @ericangeles @tmcconechy

Thanks!

@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.57.x (Oct 2021) Sprint Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: appbuilder Issues for the App builder team timebox Timebox this issue to solve quickly or defer to later type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants