Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: Add virtual scrolling #4708

Closed
tmcconechy opened this issue Dec 22, 2020 · 2 comments · Fixed by #4792
Closed

Dropdown: Add virtual scrolling #4708

tmcconechy opened this issue Dec 22, 2020 · 2 comments · Fixed by #4792
Assignees
@tmcconechy
Labels
focus: performance ⚡ Main focus is for improving performance team: CRM CRM issues and features type: enhancement ✨ [5] Velocity rating (Fibonacci)
Projects
Enterprise 4.37.x (Jan 2021) Sprint

Comments

@tmcconechy
Copy link
Member

Describe the bug
Need to further speed up http://localhost:4000/components/dropdown/test-8000-items.html in particular opening and closing is too slow. Will make the following work

  • virtual scroll from 5.0 (WC)
  • opening/closing is fast
  • rendering page is fast
  • tooltips work
  • filter style search works

To Reproduce
Steps to reproduce the behavior:

  1. Go to http://localhost:4000/components/dropdown/test-8000-items.html
  2. Click on dropdown to open

Expected behavior
Fast as possible. We think virtual scrolling will help

Version

  • ids-enterprise: [e.g. v4.35

Platform*

  • CRM
  • Chrome
@tmcconechy tmcconechy self-assigned this Dec 22, 2020
@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) focus: performance ⚡ Main focus is for improving performance team: CRM CRM issues and features type: enhancement ✨ labels Dec 22, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.36.x (Dec 2020) Sprint via automation Dec 22, 2020
@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.36.x (Dec 2020) Sprint Dec 23, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.37.x (Jan 2021) Sprint via automation Jan 19, 2021
@tmcconechy
Copy link
Member Author

Marking as 4.37 for now as it is an enhancement -> will patch if necessary when complete

@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.37.x (Jan 2021) Sprint Jan 19, 2021
This was referenced Jan 29, 2021
Closed
Merged
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.37.x (Jan 2021) Sprint Jan 29, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.37.x (Jan 2021) Sprint Feb 1, 2021
@jbrcna
Copy link
Contributor

jbrcna commented Feb 2, 2021

QA Passed with observation
v4.37.0-beta0
https://4370-beta0-enterprise.demo.design.infor.com/components/dropdown/example-virtual-scroll.html

Chrome
this is what a toast looks like in Mac/Chrome. I guess this might be some cache issue as this works fine using incognito mode
image

Safari
the dropdown resizes when you search
Large GIF (586x414)

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.37.x (Jan 2021) Sprint Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmcconechy tmcconechy

Labels
focus: performance ⚡ Main focus is for improving performance team: CRM CRM issues and features type: enhancement ✨ [5] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.37.x (Jan 2021) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4708 - Dropdown Virtual scroll infor-design/enterprise
2 participants
@tmcconechy @jbrcna