Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs: If info icon is used rather than error icon , it then overlaps #4711

Closed
marknolaninfor opened this issue Dec 23, 2020 · 3 comments · Fixed by #4733 or #4759
Closed

Tabs: If info icon is used rather than error icon , it then overlaps #4711

marknolaninfor opened this issue Dec 23, 2020 · 3 comments · Fixed by #4733 or #4759
Assignees
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@marknolaninfor
Copy link
Collaborator

marknolaninfor commented Dec 23, 2020

Describe the bug
The test given for the bug #2695 was not valid as http://master-enterprise.demo.design.infor.com/components/tabs/test-modal-error.html should have been altered so that it had an info validation rule.

The difference is that when the rule runs it apply the is-info and not the is-error class on the tab. Another issue is that the inline message on the field does not display.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'http://master-enterprise.demo.design.infor.com/components/tabs/test-modal-error.html'
  2. Run the custom Rule code to add in info rule to the field
  3. Enter the 'Test' value
  4. See overlap

Expected behavior
The icons and message should display in the same way as an error

Version

  • ids-enterprise: master

Screenshots
class on tab
image
overlap
image

Platform

  • Infor Application/Team Name: Pathway
  • OS Version: Windows 10
  • Browser Name: chrome

Additional context

Script to add custom rule

// Custom Rule
$.fn.validation.rules.customRule = {
	check: function (value, field) {
		var pass = false;
        if (value !== 'Test') {
			pass = true;
		}
        return pass;
    },
    message: 'Information message',
    type: 'info',
    id: 'customDynamicRule'
};

// Change the validation attribute on the field
$('#last-name').attr('data-validate', 'required customRule');
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 labels Dec 23, 2020
@ericangeles ericangeles self-assigned this Jan 12, 2021
@ericangeles ericangeles added this to To do in Enterprise 4.37.x (Jan 2021) Sprint via automation Jan 12, 2021
@ericangeles ericangeles moved this from To do to Pending Review in Enterprise 4.37.x (Jan 2021) Sprint Jan 12, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.37.x (Jan 2021) Sprint Jan 19, 2021
@marknolaninfor
Copy link
Collaborator Author

only the info icon was corrected, but there are other validation types, such as alert, success.

Enterprise 4.37.x (Jan 2021) Sprint automation moved this from Ready for QA (beta) to To do Jan 20, 2021
@tmcconechy
Copy link
Member

@ericangeles can you add the other types please? Thanks!

@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.37.x (Jan 2021) Sprint Jan 21, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.37.x (Jan 2021) Sprint Jan 22, 2021
@janahintal
Copy link
Contributor

This issue is now resolved. Thank you.
image

@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.37.x (Jan 2021) Sprint Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
4 participants