Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid: Allow Shift + Click to select a range of rows from the selection checkboxes when selectable is 'mixed' #4748

Closed
claudenbach opened this issue Jan 15, 2021 · 2 comments · Fixed by #4826
Assignees
Labels
team: landmark For Landmark issues type: enhancement ✨ [2] Velocity rating (Fibonacci)

Comments

@claudenbach
Copy link
Contributor

Describe the bug:
Allow the Shift + Click behavior on the selection checkboxes to select a range of rows when the selectable mode is 'mixed'. Currently this behavior is only provided when a user performs a range selection from list cells other than the selection checkbox.

Steps to reproduce the behavior:

  1. Go to https://master-enterprise.demo.design.infor.com/components/datagrid/example-mixed-selection.html
  2. Click on selection checkbox on first row
  3. With Shift + Click on the third row
  4. Only the third row is selected

Expected behavior
Range of rows within the selection should be selected. Want the same behavior that currently already exists for range selection from when its not the selection checkbox. So row selection events are emitted and a single row activation event is emitted for the last row within the selection.

Version

  • ids-enterprise: v4.37.0-dev
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) team: landmark For Landmark issues type: enhancement ✨ labels Jan 15, 2021
@claudenbach
Copy link
Contributor Author

Git-4748

@tmcconechy tmcconechy added this to To do in Enterprise 4.38.x (Feb 2021) Sprint via automation Jan 22, 2021
@tmcconechy tmcconechy removed the [2] Velocity rating (Fibonacci) label Feb 8, 2021
@tmcconechy tmcconechy self-assigned this Feb 8, 2021
@tmcconechy tmcconechy added the [2] Velocity rating (Fibonacci) label Feb 8, 2021
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.38.x (Feb 2021) Sprint Feb 8, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.38.x (Feb 2021) Sprint Feb 10, 2021
@janahintal
Copy link
Contributor

QA Passed. Working as expected.
image
image

@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.38.x (Feb 2021) Sprint Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: landmark For Landmark issues type: enhancement ✨ [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants