Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Menu: Change icon when closed back to hamburger #4756

Closed
tmcconechy opened this issue Jan 20, 2021 · 2 comments · Fixed by #4758
Closed

App Menu: Change icon when closed back to hamburger #4756

tmcconechy opened this issue Jan 20, 2021 · 2 comments · Fixed by #4758
Assignees
@EdwardCoyle
Labels
type: regression bug ↩️ [1] Velocity rating (Fibonacci)
Projects
Enterprise 4.36.x (Dec 2020) Sprint Enterprise 4.37.x (Jan 2021) Sprint

Comments

@tmcconechy
Copy link
Member

Describe the bug
Decided to revert the recent change that made the hamburger into an X on open back to a hamburger due to complaints by customers. I.E. its always a hamburger and doesnt morph into an x like previous versions

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://master-enterprise.demo.design.infor.com/components/applicationmenu/example-personalized.html
  2. Click on hamburger
  3. See it morph to an x

Expected behavior
Works like https://4340-enterprise.demo.design.infor.com/components/applicationmenu where it is not an X when open.

Version

  • ids-enterprise: [e.g. v4.36]

Additional context
Seems this can be fixed by not adding the close class to class="icon app-header close"
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) [3] Velocity rating (Fibonacci) type: bug 🐛 type: regression bug ↩️ [1] Velocity rating (Fibonacci) and removed [3] Velocity rating (Fibonacci) type: bug 🐛 [2] Velocity rating (Fibonacci) labels Jan 20, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.36.x (Dec 2020) Sprint via automation Jan 20, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.37.x (Jan 2021) Sprint via automation Jan 20, 2021
@tmcconechy
Copy link
Member Author

We might patch this to 4.36 but keep it in master for now.

@tmcconechy tmcconechy mentioned this issue Jan 20, 2021
Closed
@EdwardCoyle EdwardCoyle self-assigned this Jan 20, 2021
@EdwardCoyle EdwardCoyle mentioned this issue Jan 20, 2021
Merged
1 task
@EdwardCoyle EdwardCoyle moved this from To do to Pending Review in Enterprise 4.37.x (Jan 2021) Sprint Jan 20, 2021
@tmcconechy tmcconechy moved this from Done to To Patch in Enterprise 4.36.x (Dec 2020) Sprint Jan 22, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.37.x (Jan 2021) Sprint Jan 22, 2021
@jbrcna
Copy link
Contributor

jbrcna commented Jan 25, 2021

QA Passed
v4.3.7.0-dev
https://master-enterprise.demo.design.infor.com/components/applicationmenu/example-personalized.html

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.37.x (Jan 2021) Sprint Jan 25, 2021
@tmcconechy tmcconechy moved this from To Patch to Patched 4.36.2 in Enterprise 4.36.x (Dec 2020) Sprint Jan 25, 2021
@tmcconechy tmcconechy mentioned this issue Mar 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EdwardCoyle EdwardCoyle

Labels
type: regression bug ↩️ [1] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.36.x (Dec 2020) Sprint
  
Patched 4.36.2
Enterprise 4.37.x (Jan 2021) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4756 - Remove App Menu trigger button's close button animation infor-design/enterprise
3 participants
@tmcconechy @EdwardCoyle @jbrcna