Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timepicker - Translation - Greek Language issue - Truncated AM/PM translation in Set Time control #4793

Closed
dhumalkishor opened this issue Feb 1, 2021 · 7 comments · Fixed by #5068
Assignees
Labels
focus: translation For translation issues team: Infor GRC For GRC Issues type: bug 🐛 [3] Velocity rating (Fibonacci)

Comments

@dhumalkishor
Copy link

Describe the bug
In Time picker when we set Greek language it not showing full test for AM/PM. It is showing only first letter. Please refer below screenshots.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Enterprise-ng project - locale-initializer and set the language to "el-GR" '
  2. Go to Time picker Example and click on "Standard Time (h:mm:ss a)" and set the AM/PM and apply.
  3. Again click on that control and check the AM/PM values.

Expected behavior
It should show full test for AM/PM.
Version

  • ids-enterprise: [e.g. v4.9.0 or v4.10.0]

Screenshots
If applicable, add screenshots to hel
TP1
TP2

p explain your problem.

Platform

  • Infor Application/Team Name: [e.g. Infor XYZ, Infor ABC]
  • Device: (if applicable) [e.g. iPhone 6 or Samsung Galaxy S6]
  • OS Version: [e.g. Windows 10 or iOS 8]
  • Browser Name: [e.g. chrome, safari, stock browser]
  • Browser Version: [e.g. 22, 66.0.3359.181 (Official Build) (64-bit)]

Additional context
Add any other context about the problem here.

@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) type: bug 🐛 labels Feb 1, 2021
@tmcconechy tmcconechy changed the title Time Picker - Translation - Greek Language issue - Truncated AM/PM translation in Set Time control Timepicker - Translation - Greek Language issue - Truncated AM/PM translation in Set Time control Feb 1, 2021
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) and removed [3] Velocity rating (Fibonacci) labels Feb 1, 2021
@tmcconechy
Copy link
Member

tmcconechy commented Feb 1, 2021

We would have to make the dropdown a bit wider on the dialog. What is your team's name?

@cpinatel7
Copy link

It's for GRC. Issue raised by my Greek tester. Thanks

@tmcconechy tmcconechy added focus: translation For translation issues team: Infor GRC For GRC Issues status: clarification Issue needs clarification labels Feb 3, 2021
@tmcconechy
Copy link
Member

Trying to reproduce this in the component https://master-enterprise.demo.design.infor.com/components/datepicker/example-timeformat.html?locale=el-GR and im not sure that i can. I see enough room for the last column (last input)

@cpinatel7
Copy link

One character is missing by default. Example:

Clarification

Thanks

@tmcconechy tmcconechy removed the status: clarification Issue needs clarification label Feb 10, 2021
@prasannapatil91infor
Copy link

Hello @tmcconechy ,
we are faceing one more issue related to this, We are trying to parse date as bellow, it is giving same result for AM and PM.
Soho.Locale.parseDate("25/2/2021 7:59 μ.μ.","d/M/yyyy h.mm. a");
Thu Feb 25 2021 07:59:00 GMT+0530 (India standerd Time)
Soho.Locale.parseDate("25/2/2021 7:59 π.μ.","d/M/yyyy h.mm. a");
Thu Feb 25 2021 07:59:00 GMT+0530 (India standerd Time)

Also we try as bellow but getting same result

Soho.Locale.parseDate("25/2/2021 7:59 π.μ.".replace('π.μ.', 'AM').replace('μ.μ.', 'PM'),"d/M/yyyy h:mm a");
Thu Feb 25 2021 07:59:00 GMT+0530 (India standerd Time)
Soho.Locale.parseDate("25/2/2021 7:59 μ.μ.".replace('π.μ.', 'AM').replace('μ.μ.', 'PM'),"d/M/yyyy h:mm a");
Thu Feb 25 2021 07:59:00 GMT+0530 (India standerd Time)

we are expecting result as bellow for PM
Soho.Locale.parseDate("25/2/2021 7:59 π.μ.","d/M/yyyy h.mm. a");
Thu Feb 25 2021 19:59:00 GMT-0500 (Eastern Standard Time)

could you resolved this issue with this ticket or should we create new ticket for this issue ?

@tmcconechy
Copy link
Member

yes i think we can do it with this.

@tmcconechy tmcconechy added this to To do in Enterprise 4.51.x (Apr 2021) Sprint via automation Mar 2, 2021
@ghost ghost added [3] Velocity rating (Fibonacci) and removed [2] Velocity rating (Fibonacci) labels Apr 5, 2021
@ghost ghost assigned deep7102 Apr 5, 2021
@deep7102 deep7102 moved this from To do to In progress in Enterprise 4.51.x (Apr 2021) Sprint Apr 9, 2021
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.51.x (Apr 2021) Sprint Apr 12, 2021
@ghost ghost moved this from Pending Review to Ready for QA (beta) in Enterprise 4.51.x (Apr 2021) Sprint Apr 14, 2021
@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.51.x (Apr 2021) Sprint Apr 14, 2021
@tmcconechy tmcconechy moved this from Done to NG Checked and Done in Enterprise 4.51.x (Apr 2021) Sprint Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: translation For translation issues team: Infor GRC For GRC Issues type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.51.x (Apr 2021) Sprint
  
NG Checked and Done
Development

Successfully merging a pull request may close this issue.

6 participants