Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage: Resize / reorder events send faulty information for Editable Homepage (Regression) #4798

Closed
volante007 opened this issue Feb 2, 2021 · 4 comments · Fixed by #4800 or #5208

Comments

@volante007
Copy link

Describe the bug
When resizing/reordering widgets in an editable Homepage, the events that fire do not send correct metadata. The events are sending the size / position the widget had before the event, not the resulting size / position.

To Reproduce

  1. Go to https://design.infor.com/code/ids-enterprise/latest/demo/components/homepage/example-editable.html
  2. Open Dev console
  3. Move Widget A (top left) to position of Widget B (top right)
  4. Inspect the event metadata being sent in the reorder event

Expected behavior
Widget A should be at index 1 in metadata blocks array. Its x value should be 2.

Actual behavior
Widget A is at index 0 in metadata blocks array. Its x value is 0.

See similar fault in the metadata blocks when resizing a widget.

Version

  • ids-enterprise: latest / 4.36.1

Screenshots
image

Additional context
Works fine on 4.35.0, https://design.infor.com/code/ids-enterprise/4.35.0/demo/components/homepage/example-editable.html
image

@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) type: regression bug ↩️ labels Feb 2, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.38.x (Feb 2021) Sprint via automation Feb 2, 2021
@tmcconechy
Copy link
Member

@deep7102 can you take a look at this (on master) if needed i can patch to 4.36 - assume its due to some recent changes.

@volante007
Copy link
Author

volante007 commented Feb 2, 2021

I'm pretty sure it's due to this change
761f3c0#diff-0a05b3a653c698030f13b241516312e126a853dd3e8f6fab78ee26aa6dd4dc41R771
Adding a timeout in refresh()

refresh() is called before dispatching the resize/reorder events. Due to the timeout, the blocks are out of date (they are updated in resize() which is called within refresh())

@jbrcna
Copy link
Contributor

jbrcna commented Feb 4, 2021

@jbrcna jbrcna moved this from Ready for QA (RC) to Done in Enterprise 4.37.x (Jan 2021) Sprint Feb 4, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.52.x (May 2021) Sprint via automation May 20, 2021
@tmcconechy tmcconechy moved this from To do to Ready for QA (beta) in Enterprise 4.52.x (May 2021) Sprint May 20, 2021
@jbrcna
Copy link
Contributor

jbrcna commented May 21, 2021

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.52.x (May 2021) Sprint May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment