Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup, date picker and time picker field does not have accessible labels, role and state info. #4820

Closed
JBismonte opened this issue Feb 8, 2021 · 6 comments · Fixed by #5030
Assignees
Labels
focus: accessibility Main focus is for accessibility priority: high team: landmark For Landmark issues [5] Velocity rating (Fibonacci)

Comments

@JBismonte
Copy link

JBismonte commented Feb 8, 2021

Describe the bug
[VPAT] Lookup, time and date picker button in fields does not have accessible labels and role and state info..

To Reproduce

  1. open screenreader
  2. go to: https://master-enterprise.demo.design.infor.com/components/field-options/example-index
  3. hover over the lookup, date or timepicker buttons, the buttons are not announced.
  4. Also do this in web components...

Expected behavior
VPAT Recommendation:
Ensure the following information is conveyed for each control:

  1. A meaningful label describing the function/purpose of the control (e.g. "Look up").
  2. A role to inform users of how the control functions (e.g. by wrapping the control in a element, or in an element with role="button").
    see example compliant code for the lookup control:
<span class="lookup-wrapper sm">
    <input>
    <button class="trigger">
        <span class=sr-only">Look up</span>
        <svg class="icon" focusable="false" aria-hidden="true" role="presentation">
            ...
        </svg>
    </button>
</span> 

Version

  • ids-enterprise: v4.36.2 and v4.38.0-dev

Screenshots
image

Platform

  • Infor Application/Team Name: Infor Landmark
  • Device: (if applicable) : NA
  • OS Version: Windows 10
  • Browser Name: firefox
  • Browser Version: 85.0 (64-bit)

Additional context
https://jira.lawson.com/browse/LMCLIENT-34219

@tmcconechy
Copy link
Member

Which component are you referencing @JBismonte ? The screen shot shows field options but lookup, date or timepicker. Is it all 4? Or one specifically?

@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) focus: accessibility Main focus is for accessibility team: landmark For Landmark issues labels Feb 8, 2021
@tmcconechy
Copy link
Member

Also relates to #4127 i think once we HAVE a tab stop it also needs the label. So basically the same issue there

@ceszilla
Copy link

ceszilla commented Feb 9, 2021

marking as on of the identified high priority items, fyi

@tmcconechy tmcconechy added this to To do in Enterprise 4.50.x (Mar 2021) Sprint via automation Feb 9, 2021
@tmcconechy tmcconechy changed the title Lookup date and time picker field does not have accessible labels, role and state info. Lookup, date picker and time picker field does not have accessible labels, role and state info. Mar 4, 2021
@EdwardCoyle EdwardCoyle self-assigned this Mar 25, 2021
@EdwardCoyle EdwardCoyle moved this from To do to In progress in Enterprise 4.50.x (Mar 2021) Sprint Mar 25, 2021
@tmcconechy
Copy link
Member

As discussed lets add a tabbable setting to trigger fields. In 4.x it will be false and in 5.x it will be true.
I think this should be working fine in WC but you can test it quick if you want.

@EdwardCoyle EdwardCoyle moved this from In progress to Pending Review in Enterprise 4.50.x (Mar 2021) Sprint Mar 31, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (master) in Enterprise 4.50.x (Mar 2021) Sprint Apr 2, 2021
@janahintal
Copy link
Contributor

Hi @tmcconechy , I noticed that everytime I open the datepicker, time and lookup here https://master-enterprise.demo.design.infor.com/components/form/example-compact-mode.html? the entire page reloads again.

@janahintal janahintal moved this from Ready for QA (master) to Failed QA (beta) in Enterprise 4.50.x (Mar 2021) Sprint Apr 6, 2021
@tmcconechy
Copy link
Member

@janahintal i made an update so it wont do that anymore. But the link is now on https://main-enterprise.demo.design.infor.com/components/form/example-compact-mode.html as we renamed main to master. And it will require #5052 to be merged

@tmcconechy tmcconechy moved this from Failed QA (beta) to Pending Review in Enterprise 4.50.x (Mar 2021) Sprint Apr 6, 2021
@tmcconechy tmcconechy moved this from Pending Review to Patch 1 in Enterprise 4.50.x (Mar 2021) Sprint Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: accessibility Main focus is for accessibility priority: high team: landmark For Landmark issues [5] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants