Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Menu: Trigger styling not correct #4842

Closed
whernebrink opened this issue Feb 15, 2021 · 1 comment · Fixed by #4846
Closed

Application Menu: Trigger styling not correct #4842

whernebrink opened this issue Feb 15, 2021 · 1 comment · Fixed by #4846
Assignees
Labels
type: bug 🐛 [1] Velocity rating (Fibonacci)

Comments

@whernebrink
Copy link

Describe the bug
When using the options below for soho-tabs (moduleTabs = true), the icon does not appear centered in the application-menu-trigger list item:

To Reproduce
Enable appMenuTrigger for soho-tabs (moduleTabs) and set appMenuTriggerTextAudible to true.

{
  appMenuTrigger: true,
  appMenuTriggerTextAudible: true
}

Steps to reproduce the behavior:

  1. Clone repo https://github.com/whernebrink/module-tabs-issue
  2. Install deps and npm start

Expected behavior
Menu icon should be centered in the application-menu-trigger list item.

Version

  • ids-enterprise: v4.37.0 (enterprise-ng v9.1.5)

Screenshots
Screenshot 2021-02-15 at 15 00 38

Platform

  • Infor Application/Team Name: M3
  • OS Version: OSX Catalina
  • Browser Name: chrome
  • Browser Version: 88.0.4324.96 (Official Build) (x86_64)
@tmcconechy tmcconechy added [1] Velocity rating (Fibonacci) type: bug 🐛 labels Feb 16, 2021
@tmcconechy tmcconechy changed the title Application menu trigger styling not correct Application Menu: Trigger styling not correct Feb 16, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.50.x (Mar 2021) Sprint via automation Feb 16, 2021
@tmcconechy tmcconechy self-assigned this Feb 16, 2021
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.50.x (Mar 2021) Sprint Feb 16, 2021
@tmcconechy tmcconechy removed this from Pending Review in Enterprise 4.50.x (Mar 2021) Sprint Feb 16, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.38.x (Feb 2021) Sprint via automation Feb 16, 2021
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.38.x (Feb 2021) Sprint Feb 16, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.38.x (Feb 2021) Sprint Feb 18, 2021
@janahintal
Copy link
Contributor

QA Passed. Thank you!
image
Uploading image.png…

@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.38.x (Feb 2021) Sprint Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [1] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants