Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment: Fix feature detection for Ipad #4855

Closed
tmcconechy opened this issue Feb 18, 2021 · 1 comment · Fixed by #4856
Closed

Environment: Fix feature detection for Ipad #4855

tmcconechy opened this issue Feb 18, 2021 · 1 comment · Fixed by #4856
Assignees
Labels
type: bug 🐛 [1] Velocity rating (Fibonacci)

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Feb 18, 2021

Describe the bug
in ipad ios 13 the feature detection changed:

I opened Settings -> Safari -> Request Desktop Website -> All websites. That option is enabled by default. I disabled it and the proper User Agent is now displayed.

Mozilla/5.0 (iPad; CPU OS 13_0 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0 Mobile/15E148 Safari/604.1

IMO it should be disabled by default and if a user enables it a modal window should be displaying indicating not all web sites will be supported properly. Or maybe you may consider to add the iPad word to the first user agent to allow us to detect if it is an ipad emulating safari desktop or enable mouse event emulation, because I think when it is released several websites will fail.

To Reproduce

Steps to reproduce the behavior:

  1. Go to http://localhost:4000/components/environment/example-browser-specs.html
  2. Compare this page on ipad 11, 12, 13, 14 -> 13 and 14 are wrong

Expected behavior
Correct detection on ios 13 and 14

Platform

  • Device: ipad
  • OS Version: 13/14
  • Browser Name: safari
@tmcconechy tmcconechy self-assigned this Feb 18, 2021
@tmcconechy tmcconechy added [1] Velocity rating (Fibonacci) type: bug 🐛 labels Feb 18, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.38.x (Feb 2021) Sprint via automation Feb 18, 2021
@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.38.x (Feb 2021) Sprint Feb 18, 2021
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.38.x (Feb 2021) Sprint Feb 18, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.38.x (Feb 2021) Sprint Feb 22, 2021
@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.38.x (Feb 2021) Sprint Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [1] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants