Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sink Page: Button and Single Select Lookup Component Alignment Issue #4933

Closed
CindyMercadoReyes opened this issue Mar 10, 2021 · 4 comments · Fixed by #4984
Closed

Sink Page: Button and Single Select Lookup Component Alignment Issue #4933

CindyMercadoReyes opened this issue Mar 10, 2021 · 4 comments · Fixed by #4984
Assignees
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@CindyMercadoReyes
Copy link
Collaborator

Describe the bug
Sink Page: Button and Lookup Component Alignment Issue
To Reproduce

Steps to reproduce the behavior:

  1. Go to url: https://4380-rc1-enterprise.demo.design.infor.com/
  2. Scroll down to Buttons and on Primary and Secondary button the icon alignment on "New" version is off
  3. Scroll down to Single Select Lookup and click on the lookup button and type in "2142201" and click enter
  4. See error the arrow down button is not aligned correctly. Please see both screen shots attached.

Expected behavior
Icons should be aligned.

Version

  • ids-enterprise: [e.g. v4.38]

Screenshots
lookup IDS
buttons IDS

Platform

  • OS Version: [ iOS 8]
  • Browser Name: [All Browsers]

Additional context
Add any other context about the problem here.
None

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 [1] Velocity rating (Fibonacci) and removed [2] Velocity rating (Fibonacci) [1] Velocity rating (Fibonacci) labels Mar 10, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.50.x (Mar 2021) Sprint via automation Mar 16, 2021
@danielortiz1982 danielortiz1982 moved this from To do to In progress in Enterprise 4.50.x (Mar 2021) Sprint Mar 16, 2021
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.50.x (Mar 2021) Sprint Mar 23, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (master) in Enterprise 4.50.x (Mar 2021) Sprint Mar 24, 2021
@janahintal
Copy link
Contributor

janahintal commented Mar 25, 2021

Failing in Classic theme.
Verified in https://master-enterprise.demo.design.infor.com/components/lookup/example-index.html?theme=classic&mode=light&colors=2578a9

Kindly see the image below. The 'x' button is not visible.
image

@janahintal janahintal moved this from Ready for QA (master) to Failed QA (beta) in Enterprise 4.50.x (Mar 2021) Sprint Mar 25, 2021
@tmcconechy
Copy link
Member

cc @danielortiz1982 can you make a follow up PR for this to fix. i can see as noted that its not working in classic theme.
After rechecking your PR the problem is the fix was put into lookup-new.scss this only applies to new theme. So perhaps the fix needs to be moved to lookup.scss then it will either work in both new/classic "versions". If any minor adjustment is additionally needed for only new theme then it goes into lookup-new

@danielortiz1982
Copy link
Contributor

@tmcconechy will do, I will have a look this morning.

@tmcconechy
Copy link
Member

@janahintal for the last part can you make a new issue if you still see that on master, we will have to table it for now

@tmcconechy tmcconechy moved this from Failed QA (beta) to Done in Enterprise 4.50.x (Mar 2021) Sprint Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
4 participants