Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid: Expand button animation is cut off #4962

Closed
arturchilangwa-infor opened this issue Mar 17, 2021 · 1 comment · Fixed by #5196
Closed

Datagrid: Expand button animation is cut off #4962

arturchilangwa-infor opened this issue Mar 17, 2021 · 1 comment · Fixed by #5196
Assignees
Labels
priority: trival Least important issues type: bug 🐛 [1] Velocity rating (Fibonacci)

Comments

@arturchilangwa-infor
Copy link

Description
An animation cut off when clicking on the "expand-button" (plus or minus sign) on a SohoDataGrid that is multiselectable. This happens only if the row is selected.

To Reproduce

  1. Go to https://master-enterprise.demo.design.infor.com/components/datagrid/test-expandable-row-multiselect.html

  2. Select/check a row first so it has a blue background

  3. Press on the button that expands row (the animation cut off will appear here)

Expected behavior
The animation for "expand-button" should be a whole circle with no oddity to the animtaion

Version

  • ids-enterprise-ng: v4.38.0

Screenshots
Animation cut off
animation-cut-off2

Animation cut off close up
animation-cutoff_closeup

Potential element that produces the error

Platform

  • Device: Desktop
  • OS Version: Windows 10
  • Browser Name: Chrome
  • Browser Version: 88.0.4324.190 (Official Build) (64-bit)

Additional context
The potential element that makes bug.
animation-cut-off-with-inspector

The element is the <span class="icon plus-minus"></span> inside of the button-element.

<div class="datagrid-cell-wrapper">
    <button type="button" aria-label="Expand / Collapse" class="btn-icon datagrid-expand-btn hide-focus" tabindex="-1">
        <span class="icon plus-minus"></span>
    </button>
    <span> 2142201</span>
</div> 
@tmcconechy tmcconechy transferred this issue from infor-design/enterprise-ng Mar 18, 2021
@tmcconechy tmcconechy changed the title SohoGrid "expand-button" animation cut off Datagrid: Expand button animation is cut off Mar 18, 2021
@tmcconechy tmcconechy added [1] Velocity rating (Fibonacci) type: bug 🐛 priority: trival Least important issues labels Mar 18, 2021
@tmcconechy tmcconechy self-assigned this May 14, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.52.x (May 2021) Sprint via automation May 14, 2021
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.52.x (May 2021) Sprint May 14, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.52.x (May 2021) Sprint May 25, 2021
@jbrcna
Copy link
Contributor

jbrcna commented May 26, 2021

QA Passed
The animation for "expand-button" is now a whole circle with no oddity to the animtaion (both selected/unselected)
v4.52.0-dev
https://main-enterprise.demo.design.infor.com/components/datagrid/test-expandable-row-multiselect.html

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.52.x (May 2021) Sprint May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: trival Least important issues type: bug 🐛 [1] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants