Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circle: Circle pager not working correctly on Android #4966

Closed
CindyMercadoReyes opened this issue Mar 18, 2021 · 5 comments · Fixed by #5060
Closed

Circle: Circle pager not working correctly on Android #4966

CindyMercadoReyes opened this issue Mar 18, 2021 · 5 comments · Fixed by #5060
Assignees
@ericangeles
Labels
timebox Timebox this issue to solve quickly or defer to later type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
Enterprise 4.51.x (Apr 2021) Sprint

Comments

@CindyMercadoReyes
Copy link
Collaborator

Describe the bug
Report two issues in one ticket.
https://master-enterprise.demo.design.infor.com/components/circlepager/example-index.html – on first load, try navigating by clicking the circles. it's not moving to the next item. Clicking Next or Prev button is working as expected.

https://master-enterprise.demo.design.infor.com/components/circlepager/example-tabs.html – this one is broken in uplift. Soho is fine

To Reproduce

Steps to reproduce the behavior:
Report two issues in one ticket.
https://master-enterprise.demo.design.infor.com/components/circlepager/example-index.html – on first load, try navigating by clicking the circles. it's not moving to the next item. Clicking Next or Prev button is working as expected.

https://master-enterprise.demo.design.infor.com/components/circlepager/example-tabs.html – this one is broken in uplift. Soho is fine

Expected behavior
A clear and concise description of what you expected to happen.
The circle pager should be working as expected.

Version

  • ids-enterprise: [e.g. v4.9.0 or v4.10.0]

Screenshots
If applicable, add screenshots to help explain your problem.
None

Platform

  • Devices: [e.g. Android]

Additional context
Add any other context about the problem here.
None
@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) type: bug 🐛 labels Mar 18, 2021
@tmcconechy tmcconechy changed the title Circle Component: Circle paper not working correctly on Android Circle: Circle paper not working correctly on Android Mar 18, 2021
@ericangeles ericangeles self-assigned this Mar 29, 2021
@ericangeles
Copy link
Contributor

Hi @CindyMercadoReyes what was the specific issue in https://master-enterprise.demo.design.infor.com/components/circlepager/example-tabs.html?

What I am seeing are the issues on dropdown caret icon

Screen Shot 2021-03-29 at 6 02 53 PM

Screen Shot 2021-03-29 at 6 02 36 PM

@tmcconechy
Copy link
Member

@eric i fixed the popup issue here (separate issue) #5008
Are you not able to reproduce the steps here?

@ericangeles
Copy link
Contributor

@eric i fixed the popup issue here (separate issue) #5008
Are you not able to reproduce the steps here?

Haven't seen your PR. Let me look at it. Thanks, @tmcconechy 👍🏼

@tmcconechy tmcconechy added this to To do in Enterprise 4.52.x (May 2021) Sprint via automation Apr 5, 2021
@tmcconechy tmcconechy added the timebox Timebox this issue to solve quickly or defer to later label Apr 5, 2021
@ghost ghost changed the title Circle: Circle paper not working correctly on Android Circle: Circle pager not working correctly on Android Apr 5, 2021
@ghost ghost removed this from To do in Enterprise 4.52.x (May 2021) Sprint Apr 5, 2021
@ghost ghost added this to To do in Enterprise 4.51.x (Apr 2021) Sprint via automation Apr 5, 2021
@ghost ghost moved this from To do to In progress in Enterprise 4.51.x (Apr 2021) Sprint Apr 5, 2021
@ericangeles ericangeles mentioned this issue Apr 7, 2021
Merged
1 task
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.51.x (Apr 2021) Sprint Apr 7, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.51.x (Apr 2021) Sprint Apr 13, 2021
@jbrcna
Copy link
Contributor

jbrcna commented Apr 14, 2021 •
edited

QA Passed
this is working as expected using a real device. just noting some observations when using Browserstack. kindly see screenshot for reference

https://main-enterprise.demo.design.infor.com/components/circlepager/example-index.html - No circle buttons
Samsung Galaxy S21 Browserstack
image

https://main-enterprise.demo.design.infor.com/components/circlepager/example-tabs.html
image

@CindyMercadoReyes
Copy link
Collaborator Author

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.51.x (Apr 2021) Sprint Apr 14, 2021
@tmcconechy tmcconechy moved this from Done to NG Checked and Done in Enterprise 4.51.x (Apr 2021) Sprint Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericangeles ericangeles

Labels
timebox Timebox this issue to solve quickly or defer to later type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.51.x (Apr 2021) Sprint
  
NG Checked and Done
Milestone
No milestone
4 participants
@tmcconechy @ericangeles @CindyMercadoReyes @jbrcna