Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header: 3rd Header is in gray font, when the others are white. #5003

Closed
CindyMercadoReyes opened this issue Mar 25, 2021 · 4 comments · Fixed by #5019
Closed

Header: 3rd Header is in gray font, when the others are white. #5003

CindyMercadoReyes opened this issue Mar 25, 2021 · 4 comments · Fixed by #5019
Assignees
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@CindyMercadoReyes
Copy link
Collaborator

Describe the bug
Notice the third list"Header" item have too much contrast. (Uplift – High Contrast) . Not sure if it makes sense.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://master-enterprise.demo.design.infor.com/components/header/example-breadcrumbs
  2. Click on "Level two detail view"
  3. Notice the third list"Header" item have too much contrast. (Uplift – High Contrast) . Not sure if it makes sense.
  4. The header should be the same color as the other headers

Expected behavior
The header should be the same color as the others. Please see screen shot attached

Version

  • ids-enterprise: [ v4.39.0]

Screenshots
Header Error

Platform

  • All Browser Name:

Additional context
Add any other context about the problem here.
None

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 labels Mar 25, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.50.x (Mar 2021) Sprint via automation Mar 26, 2021
@tmcconechy
Copy link
Member

Can take at this one - i almost thought it was a regression for the previous fix on breadcrumb but i think its a new similar issue

@chrisakinrinade
Copy link
Contributor

@tmcconechy so the third breadcrumb is greyed out because it's class = "current". Should current breadcrumbs not be colored differently?

@tmcconechy
Copy link
Member

@chrisakinrinade - the "current" link in bread crumb shows the active one on the page. So it shouldnt be greyed out. In the normal context its "heavier" https://master-enterprise.demo.design.infor.com/components/breadcrumb/example-index.html

I think maybe the solution is to remove the color from it and just make current apply a bold style and not change the color. That should work in both the default example and the color background examples..

Screen Shot 2021-03-29 at 11 29 52 AM

Either that or make current #fffff (white) and bold when on the color background

@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.50.x (Mar 2021) Sprint Mar 29, 2021
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.50.x (Mar 2021) Sprint Mar 31, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (master) in Enterprise 4.50.x (Mar 2021) Sprint Apr 1, 2021
@CindyMercadoReyes
Copy link
Collaborator Author

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (master) to Done in Enterprise 4.50.x (Mar 2021) Sprint Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants