Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListView: Changing selectable from 'mixed' to 'single' does not remove checkboxes #5048

Closed
claudenbach opened this issue Apr 2, 2021 · 2 comments · Fixed by #5131
Closed

ListView: Changing selectable from 'mixed' to 'single' does not remove checkboxes #5048

claudenbach opened this issue Apr 2, 2021 · 2 comments · Fixed by #5131
Assignees
@ericangeles
Labels
team: landmark For Landmark issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
Enterprise 4.51.x (Apr 2021) Sprint

Comments

@claudenbach
Copy link
Contributor

claudenbach commented Apr 2, 2021 •
edited by tmcconechy

Describe the bug
Changing the selectable input on a listview from 'mixed' to 'single' is not removing the checkboxes. It works from when changing the selectable input from 'single' to 'mixed'.

To Reproduce

  • Render a listview with selectable set to 'mixed'
  • Change the selectable to 'single' (using the updated(newSettings) method)
  • Notice that the checkboxes are still rendered

Expected behavior
When setting the selectable to 'single', checkboxes should not be rendered

Version

  • ids-enterprise: v4.37.3
@claudenbach
Copy link
Contributor Author

Git-5048

@claudenbach claudenbach added the team: landmark For Landmark issues label Apr 2, 2021
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 labels Apr 2, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.52.x (May 2021) Sprint via automation Apr 2, 2021
@ghost ghost assigned ericangeles Apr 5, 2021
@ghost ghost removed this from To do in Enterprise 4.52.x (May 2021) Sprint Apr 5, 2021
@ghost ghost added this to To do in Enterprise 4.51.x (Apr 2021) Sprint via automation Apr 5, 2021
@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.51.x (Apr 2021) Sprint Apr 16, 2021
@ericangeles ericangeles mentioned this issue Apr 23, 2021
Merged
1 task
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.51.x (Apr 2021) Sprint Apr 23, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.51.x (Apr 2021) Sprint Apr 28, 2021
@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.51.x (Apr 2021) Sprint Apr 28, 2021
@tmcconechy tmcconechy moved this from Done to NG Checked and Done in Enterprise 4.51.x (Apr 2021) Sprint Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericangeles ericangeles

Labels
team: landmark For Landmark issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.51.x (Apr 2021) Sprint
  
NG Checked and Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5048 - Fix selectable setting from mixed to single to remove checkboxes infor-design/enterprise
4 participants
@tmcconechy @ericangeles @CindyMercadoReyes @claudenbach