Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker: Add Mobility enhancements #5075

Closed
tmcconechy opened this issue Apr 13, 2021 · 1 comment · Fixed by #5226
Closed

DatePicker: Add Mobility enhancements #5075

tmcconechy opened this issue Apr 13, 2021 · 1 comment · Fixed by #5226
Assignees
Labels
team: WFM For WFM Issues type: enhancement ✨ [5] Velocity rating (Fibonacci)

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Apr 13, 2021

Is your feature request related to a problem or use case? Please describe.
We need to add a few improvements to the datepicker so that it can be used standalone and in a smaller version.

Describe the solution you'd like

  • card popover background is removed to do this https://master-enterprise.demo.design.infor.com/components/monthview can be used already but we need to make the monthview that is in https://master-enterprise.demo.design.infor.com/components/datepicker/example-index avaialble "in page". There is an option now for it being in a datepicker but need one so the smaller one there is shown in page. Would add an example to components/monthview/example-inpage . And the example should look like the design
  • Clear and Apply actions are removed to do this just dont include buttons in the example-inpage version
  • Tapping a date can trigger and event that changes the list below (application team’s responsibility but we add the event)
    - Add swiping in our Angular web component (and HTML??) this will be done on https://github.com/infor-design/enterprise/issues/5002
  • Change “Today” action to 16px bold
  • Spacing between dates and chevrons has been improved to have enough space for a 40 to 44px hitbox (for in page version only if this is easier / breaking too much / this is optional)
  • Change date hitbox to 40 or 44px for better mobile touch points (if space allows) (for in page version only if this is easier / breaking too much / this is optional)
  • Included a legend view from the datepicker component, can we align it to the left by default? Centered is ok for the popover examples. Suggest we do this based on number of items. If they can fit in one row do it left aligned otherwise centered
  • If clicked/tapped, the toolbar title & calendar icon will pulse & expand the month view downwards... pushing other content down the page. To do this we do it in the in page example
  • Change text color for current month’s dates to slate 8 (can change all)
  • azure and slate circles are 2 instead of 1. To do this - its just part of the example in the legend colors
  • Add ‘pulse’ animation back in for buttons/dates on mobile at least?
  • Noticed that on https://main-enterprise.demo.design.infor.com/components/monthview/example-index when you click the calendar it changes the month this may be related to Calendar: Today becomes selected day on calendar in current month instead of provided day #5064
  • Adjust the month and year picker

Describe alternatives you've considered
Leaving this go for now

Additional context
See designs - we are just implementing page one (High Priority) https://www.figma.com/file/ri2Knf3KchdfdzRAeds0Ab/IDS-Mobility-v4.6?node-id=1%3A5739

@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) type: enhancement ✨ labels Apr 13, 2021
@tmcconechy tmcconechy self-assigned this Apr 13, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.52.x (May 2021) Sprint via automation Apr 13, 2021
@tmcconechy tmcconechy added the team: WFM For WFM Issues label Apr 13, 2021
@ghost ghost assigned deep7102 and unassigned tmcconechy Apr 14, 2021
@deep7102 deep7102 moved this from To do to In progress in Enterprise 4.52.x (May 2021) Sprint May 5, 2021
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.52.x (May 2021) Sprint May 26, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.52.x (May 2021) Sprint Jun 1, 2021
@jbrcna
Copy link
Contributor

jbrcna commented Jun 3, 2021

The issue is now resolved.
v4.52.0-beta0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: WFM For WFM Issues type: enhancement ✨ [5] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants