Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to switch on/off auto-complete in data-picker and toolbar-flex-searchfield #5092

Closed
marclouisgenedeguzman opened this issue Apr 16, 2021 · 3 comments · Fixed by #5330
Assignees
Labels
team: m3 Issues for m3 and sub teams type: enhancement ✨ [3] Velocity rating (Fibonacci)

Comments

@marclouisgenedeguzman
Copy link

Is your feature request related to a problem or use case? Please describe.
It is observed that in date-picker and search fields in toolbar that auto-complete is always set to off.
In our implementation, our application should have an option to set the date-picker and searchfield autocomplete.
It is applied on input fields right now but we cannot apply it on search fields and datepicker since autocomplete is always set to off.

Describe the solution you'd like
Ability to have an option to switch the auto complete on/off.

https://master-enterprise.demo.design.infor.com/components/datepicker/example-index.html
image

https://master-enterprise.demo.design.infor.com/components/toolbarsearchfield/example-flex-toolbar-align-with-searchfield.html
image

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: enhancement ✨ labels Apr 16, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.53.x (June 2021) Sprint via automation Apr 16, 2021
@tmcconechy tmcconechy added the team: m3 Issues for m3 and sub teams label Apr 16, 2021
@tmcconechy
Copy link
Member

Yes, it makes sense to make this a setting i think. Also whoever takes this over we should add this setting in the WC project as well.

@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) and removed [2] Velocity rating (Fibonacci) labels Apr 16, 2021
@EdwardCoyle EdwardCoyle self-assigned this Apr 27, 2021
@EdwardCoyle EdwardCoyle moved this from To do to In progress in Enterprise 4.53.x (June 2021) Sprint Jun 17, 2021
@EdwardCoyle EdwardCoyle moved this from In progress to Pending Review in Enterprise 4.53.x (June 2021) Sprint Jun 17, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.53.x (June 2021) Sprint Jun 18, 2021
@janahintal
Copy link
Contributor

Hi @tmcconechy , trying to re-test this issue. I have seen the PR that there was no test page created for this. However, may I ask the expected behavior for this fix?

I tried testing for both https://main-enterprise.demo.design.infor.com/components/datepicker/example-index.html & https://main-enterprise.demo.design.infor.com/components/toolbarsearchfield/example-flex-toolbar-align-with-searchfield.html but I haven't seen much difference. Thank you.

@tmcconechy
Copy link
Member

We dont have the ability to test this. Its only working in tests and its something that the apps can do that we cant do in the example apps. So i'll just move it to done

@tmcconechy tmcconechy moved this from Ready for QA (beta) to Done in Enterprise 4.53.x (June 2021) Sprint Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: m3 Issues for m3 and sub teams type: enhancement ✨ [3] Velocity rating (Fibonacci)
Projects
No open projects
4 participants