Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password: Reveal text feature forces autocomplete on #5099

Closed
tmcconechy opened this issue Apr 16, 2021 · 3 comments · Fixed by #5098
Closed

Password: Reveal text feature forces autocomplete on #5099

tmcconechy opened this issue Apr 16, 2021 · 3 comments · Fixed by #5098
Assignees
@tmcconechy
Labels
team: IPMC Issues for the Infor Property Managment and Construction Team type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
Enterprise 4.51.x (Apr 2021) Sprint

Comments

@tmcconechy
Copy link
Member

Describe the bug
Because the way chrome works you can't ignore autocomplete for type="password". This is an issue flagged by the security team for the recently added reveal feature. To fix this we can use -webkit-text-security: disc; instead of password type then autocomplete can be ignores

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://stackblitz.com/edit/ids-hidereveal-tsgm2h?file=index.html
  2. Type 1 and hit enter
  3. Reload
  4. Type 1 again -> see problem the security team doesnt want this

Expected behavior
A clear and concise description of what you expected to happen.

Version

  • ids-enterprise: [e.g. v4.9.0 or v4.10.0]

Screenshots
Screen Shot 2021-04-16 at 11 00 05 AM

Platform

  • Chrome

Additional context
MS Teams
@tmcconechy tmcconechy added [1] Velocity rating (Fibonacci) [2] Velocity rating (Fibonacci) type: bug 🐛 labels Apr 16, 2021
@tmcconechy tmcconechy self-assigned this Apr 16, 2021
@tmcconechy tmcconechy removed the [1] Velocity rating (Fibonacci) label Apr 16, 2021
@tmcconechy
Copy link
Member Author

Can test the fix here https://stackblitz.com/edit/ids-hidereveal-xvhqlq?file=index.html

@tmcconechy tmcconechy added this to To do in Enterprise 4.51.x (Apr 2021) Sprint via automation Apr 16, 2021
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.51.x (Apr 2021) Sprint Apr 16, 2021
@tmcconechy tmcconechy added the team: IPMC Issues for the Infor Property Managment and Construction Team label Apr 16, 2021
@tmcconechy tmcconechy mentioned this issue Apr 19, 2021
Merged
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.51.x (Apr 2021) Sprint Apr 19, 2021
@jbrcna
Copy link
Contributor

jbrcna commented Apr 20, 2021

the issue is now resolved.
v4.51.0-dev

@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.51.x (Apr 2021) Sprint Apr 20, 2021
@tmcconechy tmcconechy moved this from Done to NG Checked and Done in Enterprise 4.51.x (Apr 2021) Sprint Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmcconechy tmcconechy

Labels
team: IPMC Issues for the Infor Property Managment and Construction Team type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.51.x (Apr 2021) Sprint
  
NG Checked and Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5099 - Change Reveal to use css instead of password infor-design/enterprise
3 participants
@tmcconechy @CindyMercadoReyes @jbrcna