Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown: Readonly dropdown doesnt have aria states #5107

Closed
tmcconechy opened this issue Apr 20, 2021 · 1 comment · Fixed by #5108
Closed

Dropdown: Readonly dropdown doesnt have aria states #5107

tmcconechy opened this issue Apr 20, 2021 · 1 comment · Fixed by #5108
Assignees
@tmcconechy
Labels
team: landmark For Landmark issues type: bug 🐛 [1] Velocity rating (Fibonacci)
Projects
Enterprise 4.51.x (Apr 2021) Sprint

Comments

@tmcconechy
Copy link
Member

Describe the bug
Found this issue conversing with the TAAS team on issues LMCLIENT-33120 / TAAS-8281. They pointed out that the readonly dropdown only has a class and no actually DOM indication of a readonly state.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://master-enterprise.demo.design.infor.com/components/dropdown/example-readonly.html
  2. Right Click on the readonly dropdown div
  3. See that it doesn't have any readonly property or aria

Expected behavior
Can add aria-reaoonly for this state.

Version

  • ids-enterprise: [e.g. v4.50.0]

Platform

  • Mac/Chrome

Additional context
https://jira.lawson.com/browse/LMCLIENT-33120
@tmcconechy tmcconechy added [1] Velocity rating (Fibonacci) team: landmark For Landmark issues type: bug 🐛 labels Apr 20, 2021
@tmcconechy tmcconechy self-assigned this Apr 20, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.51.x (Apr 2021) Sprint via automation Apr 20, 2021
@tmcconechy tmcconechy mentioned this issue Apr 20, 2021
Merged
2 tasks
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.51.x (Apr 2021) Sprint Apr 20, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.51.x (Apr 2021) Sprint Apr 22, 2021
@jbrcna
Copy link
Contributor

jbrcna commented Apr 23, 2021

This issue is now resolved. v4.51.0-dev
https://main-enterprise.demo.design.infor.com/components/dropdown/example-readonly.html
image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.51.x (Apr 2021) Sprint Apr 23, 2021
@tmcconechy tmcconechy moved this from Done to NG Checked and Done in Enterprise 4.51.x (Apr 2021) Sprint Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmcconechy tmcconechy

Labels
team: landmark For Landmark issues type: bug 🐛 [1] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.51.x (Apr 2021) Sprint
  
NG Checked and Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5107 - Add aria-readonly to dropdown infor-design/enterprise
2 participants
@tmcconechy @jbrcna