Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: Error message referenced by aria-describedby was not announced #5130

Closed
ssaniel opened this issue Apr 23, 2021 · 2 comments · Fixed by #5621
Closed

Dropdown: Error message referenced by aria-describedby was not announced #5130

ssaniel opened this issue Apr 23, 2021 · 2 comments · Fixed by #5621
Assignees
Labels
focus: accessibility Main focus is for accessibility team: landmark For Landmark issues type: bug 🐛 [3] Velocity rating (Fibonacci)

Comments

@ssaniel
Copy link

ssaniel commented Apr 23, 2021

Describe the bug
Error message referenced by aria-describedby was not announced.

To Reproduce

  1. Open up any form
  2. Supply invalid input to a dropdown
  3. Save (Error message should be visible)
  4. press 'Tab' to focus the dropdown

Expected behavior
Error message of the dropdown should be announced.

Version
ids-enterprise: 4.50.2

Platform
Infor Application/Team Name: HCM
OS Version: Windows 10
Browser Name: Chrome
Browser Version: Version 90.0.4430.85 (Official Build) (64-bit)

Additional context

  • Used NVDA and ChromeVox to test the fix
    Probably the reason why screen reader cannot announce the error message is because the focused element in the dropdown is the div not select and aria-describedby was added in select tag. Please see attached screenshot

dropdown

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) status: cant reproduce type: bug 🐛 team: landmark For Landmark issues [3] Velocity rating (Fibonacci) and removed status: cant reproduce [2] Velocity rating (Fibonacci) labels Apr 23, 2021
@tmcconechy
Copy link
Member

This can be reproduced on https://master-enterprise.demo.design.infor.com/components/dropdown/example-validation.html

  • select the blank item
  • tab back in the field

Need to somehow connect the label ? maybe add aria-described by or append to the aria-label.

@ghost ghost added the focus: accessibility Main focus is for accessibility label Apr 28, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Aug 12, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.56.x (Sept 2021) Sprint via automation Aug 16, 2021
@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.56.x (Sept 2021) Sprint Sep 15, 2021
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.56.x (Sept 2021) Sprint Sep 16, 2021
@EdwardCoyle EdwardCoyle moved this from Pending Review to Ready for QA (beta) in Enterprise 4.56.x (Sept 2021) Sprint Sep 22, 2021
@jbrcna
Copy link
Contributor

jbrcna commented Sep 23, 2021

This has been QA tested and passed on v4.56.0-dev.
verified in https://main-enterprise.demo.design.infor.com/components/dropdown/example-validation.html
image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.56.x (Sept 2021) Sprint Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: accessibility Main focus is for accessibility team: landmark For Landmark issues type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants