Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FieldOptions: wrong placement of x icon in searchfield #5138

Closed
jbrcna opened this issue Apr 27, 2021 · 4 comments · Fixed by #5238 or #5268
Closed

FieldOptions: wrong placement of x icon in searchfield #5138

jbrcna opened this issue Apr 27, 2021 · 4 comments · Fixed by #5238 or #5268
Assignees
@ericangeles
Labels
priority: trival Least important issues type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
Enterprise 4.52.x (May 2021) Sprint

Comments

@jbrcna
Copy link
Contributor

jbrcna commented Apr 27, 2021

Describe the bug
the x icon in clearable Searchfield is outside the field.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://main-enterprise.demo.design.infor.com/components/field-options/example-index.html
  2. Scroll Into Clearable Searchfield
  3. Enter some text
  4. See error
  5. Try also in compact mode

Expected behavior
image

Version

  • ids-enterprise: v4.51.0-dev

Screenshots
image

Platform
All

Additional context
Add any other context about the problem here.
@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) priority: trival Least important issues type: bug 🐛 labels Apr 27, 2021
@ericangeles ericangeles self-assigned this May 26, 2021
@ericangeles ericangeles added this to To do in Enterprise 4.52.x (May 2021) Sprint via automation May 26, 2021
@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.52.x (May 2021) Sprint May 26, 2021
@ericangeles
Copy link
Contributor

@tmcconechy @jbrcna this issue was included to this PR #5216.

@jbrcna
Copy link
Contributor Author

jbrcna commented May 26, 2021

Thanks @ericangeles

@ericangeles ericangeles mentioned this issue May 26, 2021
Merged
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.52.x (May 2021) Sprint May 26, 2021
@ericangeles ericangeles moved this from Pending Review to In progress in Enterprise 4.52.x (May 2021) Sprint May 27, 2021
@ericangeles ericangeles mentioned this issue May 27, 2021
Merged
1 task
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.52.x (May 2021) Sprint May 27, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.52.x (May 2021) Sprint Jun 1, 2021
@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.52.x (May 2021) Sprint Jun 2, 2021
@janahintal janahintal moved this from Done to Ready for QA (beta) in Enterprise 4.52.x (May 2021) Sprint Jun 2, 2021
@jbrcna
Copy link
Contributor Author

jbrcna commented Jun 2, 2021

Test Failed
The issue on the placement of x icon in searchfield is now resolved.
image
However, the test failed on the ff steps
Test this on Compact Mode, then follow above steps
Additional: Test all the components to make sure field options are align correctly
v4.52.0-beta0
https://4520-beta0-enterprise.demo.design.infor.com/components/field-options/example-index
image
screenshot (Mac/Chrome)

@jbrcna jbrcna moved this from Ready for QA (beta) to Failed QA (beta) in Enterprise 4.52.x (May 2021) Sprint Jun 2, 2021
@ericangeles ericangeles moved this from Failed QA (beta) to In progress in Enterprise 4.52.x (May 2021) Sprint Jun 3, 2021
@ericangeles ericangeles mentioned this issue Jun 3, 2021
Closed
@ericangeles ericangeles moved this from In progress to Ready for QA (beta) in Enterprise 4.52.x (May 2021) Sprint Jun 3, 2021
@ericangeles ericangeles mentioned this issue Jun 3, 2021
Merged
@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.52.x (May 2021) Sprint Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericangeles ericangeles

Labels
priority: trival Least important issues type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.52.x (May 2021) Sprint
  
Done
Milestone
No milestone
4 participants
@tmcconechy @ericangeles @CindyMercadoReyes @jbrcna