-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datagrid: Clear filter icon for a lookup is rendered to high when using the new theme #5239
Comments
@claudenbach i dont think this a bug anymore we renamed master to main so the latest link is now https://main-enterprise.demo.design.infor.com/components/datagrid/test-lookup-filter Master is now from some older point in time |
I see the issue on classic theme but i cant say what the issue is on your side? But i can address that. |
See the issue when the row height is small or extra-small and use the new theme. |
Adding this one to the current sprint as well. Can you have a look @ericangeles ? |
@tmcconechy will do. |
Failing in https://4520-beta0-enterprise.demo.design.infor.com/components/datagrid/test-lookup-filter The text in lookup field becomes empty after changing the row size, thus I'm unable to check if the icons are aligned already after changing the row size.
|
I would say, this is another separate bug. The close icon gets disappeared because the lookup field is empty. There's a class that adds to the close icon that does not make it display, though the position is still correct if you remove the |
@janahintal yes we saw this as well but decided to skip it because the example is "static". So suggest either ignoring this point or making a separate issue. (i lean to ignoring it as its not really a bug its a demo issue). You can also verify the issue but clicking the lookup in the filter and picking an item after changing the row height. |
Thanks @tmcconechy, this is noted. seems working fine on my end and the icons were aligned already after choosing from the lookup filter. I will now move this ticket to Done. |
Describe the bug:
The clear filter icon for a lookup is rendered to high in the filter row when using the new theme. Placement of the icon is correct when using the classic theme.
Steps to reproduce the behavior:
Expected behavior:
Icons in the filter row for a lookup are aligned.
Version
The text was updated successfully, but these errors were encountered: