Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid: Clear filter icon for a lookup is rendered to high when using the new theme #5239

Closed
claudenbach opened this issue May 27, 2021 · 14 comments · Fixed by #5241
Closed
Assignees
Labels
team: landmark For Landmark issues type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@claudenbach
Copy link
Contributor

Describe the bug:
The clear filter icon for a lookup is rendered to high in the filter row when using the new theme. Placement of the icon is correct when using the classic theme.

Steps to reproduce the behavior:

  1. Go to 'https://master-enterprise.demo.design.infor.com/components/datagrid/test-lookup-filter'
  2. Ensure the theme is set to New
  3. Enter a value in the Product Id filter row
  4. Notice that the clear icon is rendered to high

Expected behavior:
Icons in the filter row for a lookup are aligned.

Version

  • ids-enterprise: v4.51.0-dev
@claudenbach
Copy link
Contributor Author

image

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) status: cant reproduce labels May 27, 2021
@tmcconechy
Copy link
Member

@claudenbach i dont think this a bug anymore we renamed master to main so the latest link is now https://main-enterprise.demo.design.infor.com/components/datagrid/test-lookup-filter

Master is now from some older point in time

@claudenbach
Copy link
Contributor Author

Okay. So Landmark is seeing the icon rendered to high. Is there something that we need to change then? We recently moved to 4.51.

image

@claudenbach
Copy link
Contributor Author

Seem to be using the correct scss file....

image

@claudenbach
Copy link
Contributor Author

On the main-enterprise.demo.design.info, I'm seeing the following when using classic theme...

image

@tmcconechy
Copy link
Member

I see the issue on classic theme but i cant say what the issue is on your side? But i can address that.

@claudenbach
Copy link
Contributor Author

If I change the row height to extra-small, I'm seeing the issue on main with the new theme.

image

@claudenbach
Copy link
Contributor Author

See the issue when the row height is small or extra-small and use the new theme.

@tmcconechy
Copy link
Member

Adding this one to the current sprint as well. Can you have a look @ericangeles ?

@ericangeles
Copy link
Contributor

@tmcconechy will do.

@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.52.x (May 2021) Sprint May 28, 2021
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.52.x (May 2021) Sprint May 28, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.52.x (May 2021) Sprint Jun 1, 2021
@janahintal
Copy link
Contributor

Failing in https://4520-beta0-enterprise.demo.design.infor.com/components/datagrid/test-lookup-filter

The text in lookup field becomes empty after changing the row size, thus I'm unable to check if the icons are aligned already after changing the row size.

image

@janahintal janahintal moved this from Ready for QA (beta) to Failed QA (beta) in Enterprise 4.52.x (May 2021) Sprint Jun 2, 2021
@ericangeles
Copy link
Contributor

I would say, this is another separate bug. The close icon gets disappeared because the lookup field is empty. There's a class that adds to the close icon that does not make it display, though the position is still correct if you remove the .is-empty in close icon button.

@tmcconechy tmcconechy moved this from Failed QA (beta) to Ready for QA (beta) in Enterprise 4.52.x (May 2021) Sprint Jun 2, 2021
@tmcconechy
Copy link
Member

@janahintal yes we saw this as well but decided to skip it because the example is "static". So suggest either ignoring this point or making a separate issue. (i lean to ignoring it as its not really a bug its a demo issue). You can also verify the issue but clicking the lookup in the filter and picking an item after changing the row height.

@janahintal
Copy link
Contributor

Thanks @tmcconechy, this is noted. seems working fine on my end and the icons were aligned already after choosing from the lookup filter. I will now move this ticket to Done.

@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.52.x (May 2021) Sprint Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: landmark For Landmark issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants