Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cards: Add content variants and Improve Hitboxs #5250

Closed
tmcconechy opened this issue Jun 1, 2021 · 13 comments · Fixed by #5265, #5316, #5349, #5371 or #5399
Closed

Cards: Add content variants and Improve Hitboxs #5250

tmcconechy opened this issue Jun 1, 2021 · 13 comments · Fixed by #5265, #5316, #5349, #5371 or #5399

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Jun 1, 2021

Is your feature request related to a problem or use case? Please describe.

We want to add some examples to cards for a WFM demo and also improve the hit boxes.

Describe the solution you'd like

Design
Screen Shot 2021-06-01 at 11 38 26 AM

Additional context
See these sections on the figma sketch if needed https://www.figma.com/file/ri2Knf3KchdfdzRAeds0Ab/IDS-Mobility-v4.6?node-id=1%3A5740

And also this section:
Screen Shot 2021-06-01 at 12 37 22 PM

@janahintal
Copy link
Contributor

All examples were working as expected. However, no single action section found in the example page.
image

@tjamesallen15
Copy link
Contributor

All examples were working as expected. However, no single action section found in the example page.
image

Hello. Will work on this one tonight.

@tmcconechy tmcconechy moved this from Ready for QA (beta) to Pending Review in Enterprise 4.53.x (June 2021) Sprint Jun 15, 2021
@CindyMercadoReyes
Copy link
Collaborator

BDD added to this new enhancement.
story_github5250.docx

@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.53.x (June 2021) Sprint Jun 17, 2021
@janahintal
Copy link
Contributor

Hi @tmcconechy, I've notice a difference in tab focus of '...' button when in Classic Theme. The focus in New version looks centered but not in classic version.

New Version
image

Classic Version
image

@tmcconechy tmcconechy moved this from Ready for QA (beta) to Failed QA (beta) in Enterprise 4.53.x (June 2021) Sprint Jun 18, 2021
@tmcconechy
Copy link
Member Author

@tjamesallen15 can you look for a follow up fix? thanks!

@ghost
Copy link

ghost commented Jun 28, 2021

Design QA Feedback:

Card Component QA

Jira Ticket: https://jira.infor.com/browse/UXD-2718

QA Demo Link: https://main-enterprise.demo.design.infor.com/components/cards/example-variations-hitboxes.html

Figma File: https://www.figma.com/file/ri2Knf3KchdfdzRAeds0Ab/IDS-Mobility-v4.6?node-id=285%3A0

Feedback for Dev:

These are all the modifications that need to be made to align with the Figma file. We will start sending specific handoff links to dev so no new changes will accidentally occur on designs side.

  • First-line Body 16 Regular instead of 16 bold

  • Slate 06 instead of 03 (3rd line in item, and 2nd line in Account, Hyperlink, photocard, and single action)

  • “May, 2nd" should be “May 2nd" (Completely my mistake, not devs fault)

  • On the screenshot below, the side that contains the ellipsis/icon contains more white space than the left side. Can we get the same spacing visually?

Screen Shot 2021-06-28 at 4 32 26 PM

  • On the screenshot below, can we get the icons to line up on the side?

Screen Shot 2021-06-28 at 4 33 00 PM

  • On icons focus state should be circular when possible.

Screen Shot 2021-06-28 at 4 33 19 PM

@tmcconechy tmcconechy moved this from Failed QA (beta) to Pending Review in Enterprise 4.53.x (June 2021) Sprint Jun 29, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.53.x (June 2021) Sprint Jun 29, 2021
@tmcconechy tmcconechy moved this from Ready for QA (beta) to Pending Review in Enterprise 4.53.x (June 2021) Sprint Jun 29, 2021
@tmcconechy
Copy link
Member Author

@katieinfor two questions on this design feedback.

  1. Is this correct? I see in the screen shots the second text is a lighter color. And i think it looks better not slate06 as it has no hierarchy. So i would question this point.
    Screen Shot 2021-06-29 at 10 44 00 AM

  2. How big is the button touch point supposed to be? Isnt 50x50 too big? I feel like the old size didnt have a problem

OLD
Screen Shot 2021-06-29 at 10 45 29 AM

NEW
Screen Shot 2021-06-29 at 10 45 24 AM

@kevinwhitedesign
Copy link

@tmcconechy yeah slate 6 for accessibility was the reasoning.
and 44px hitbox minimum should be standard. cc @katieinfor @laurensteiger

@ghost ghost moved this from Pending Review to Ready for QA (beta) in Enterprise 4.53.x (June 2021) Sprint Jun 30, 2021
@janahintal
Copy link
Contributor

janahintal commented Jul 2, 2021

@tjamesallen15
Copy link
Contributor

Hello @tmcconechy ,
As the previous comment of Janah above, what would be the color schemes for the dark version for this one? I didn't handle this one because I didn't know the requirements.

cc @janahintal @ericangeles

@tmcconechy
Copy link
Member Author

tmcconechy commented Jul 6, 2021

@tjamesallen15 for that just use the same colors as in the listview examples when using themes.

https://main-enterprise.demo.design.infor.com/components/listview/example-index.html?theme=new&mode=dark&colors=0066D4

You can copy them over from there but design didnt give an exact design but this will be correct. Should we make a new issue or will you just do a follow up PR?

@ericangeles
Copy link
Contributor

@tmcconechy I have the same thing with James' issue, so I probably create a follow-up PR on expandable cards.

@tjamesallen15
Copy link
Contributor

@tmcconechy I'll make a follow up PR for this one.

@tjamesallen15 tjamesallen15 moved this from Ready for QA (beta) to Pending Review in Enterprise 4.53.x (June 2021) Sprint Jul 8, 2021
@tmcconechy tmcconechy moved this from Pending Review to Done in Enterprise 4.53.x (June 2021) Sprint Jul 12, 2021
@inforandy inforandy added the focus: dark mode dark mode label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment