Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography: Create "paragraph" text style #5325

Closed
ghost opened this issue Jun 17, 2021 · 2 comments · Fixed by #5523
Closed

Typography: Create "paragraph" text style #5325

ghost opened this issue Jun 17, 2021 · 2 comments · Fixed by #5523
Assignees
Labels
type: enhancement ✨ [3] Velocity rating (Fibonacci)

Comments

@ghost
Copy link

ghost commented Jun 17, 2021

Is your feature request related to a problem or use case? Please describe.
Jira Ticket: https://jira.infor.com/browse/UXD-2503
Our Figma file currently uses text styles with line heights that adhere to the 8 pixel grid. This works for the single-line/single-word type that is most commonly used within our designs, but these standardized line heights are often too large for instances of text with more than one line.

Describe the solution you'd like
We are proposing this solution: Line Height Figma File Page 3

Instead of a default line height associated with our type styles, we suggest a 140% line height.

For example,

font-size: 16px; line-height: 20px;
would become
font-size: 16px; line-height: 140%`

Additional context
Add any other context or screenshots about the feature request here.
This is for Design: Jira Ticket: https://jira.infor.com/browse/UXD-2503
Thanks!
image-2021-04-30-12-25-55-322
"Add users and manage permissions" is one sentence, but the large line height separates it into two independent ideas. The font size/line height in this example is 14/24.

image-2021-04-30-12-22-33-912
The sentence now clearly flows from one line to the next. The font size/line height in this example is 14/18.

@tmcconechy tmcconechy changed the title From Design to Dev: Create "paragraph" text style Typography: Create "paragraph" text style Jun 17, 2021
@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) type: enhancement ✨ labels Jun 17, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.54.x (July 2021) Sprint via automation Jun 17, 2021
@ghost ghost removed this from To do in Enterprise 4.54.x (July 2021) Sprint Jun 30, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.55.x (Aug 2021) Sprint via automation Jul 29, 2021
@tjamesallen15 tjamesallen15 moved this from To do to In progress in Enterprise 4.55.x (Aug 2021) Sprint Aug 12, 2021
@tmcconechy
Copy link
Member

tmcconechy commented Aug 12, 2021

For this issue Its just adding some classes for the line-height and checking the line-height. We do not have the icons. For this I would do two this:

  1. check the line height here https://main-enterprise.demo.design.infor.com/components/emptymessage/example-widgets.html

  2. add an example here showing line heights for text classes https://main-enterprise.demo.design.infor.com/components/typography (using p tags) and adjusting our p tag rule ect in the typography scss https://github.com/infor-design/enterprise/blob/main/src/components/typography/_typography.scss#L96

@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.55.x (Aug 2021) Sprint Aug 17, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.55.x (Aug 2021) Sprint Aug 24, 2021
@jbrcna
Copy link
Contributor

jbrcna commented Aug 25, 2021

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.55.x (Aug 2021) Sprint Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants