Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolbarFlex: Issue tabbing through with allowTabs: true #5387

Closed
tfavorite opened this issue Jul 1, 2021 · 2 comments
Closed

ToolbarFlex: Issue tabbing through with allowTabs: true #5387

tfavorite opened this issue Jul 1, 2021 · 2 comments
Labels
focus: good first issue Good for for one of the first few issues team: gtn Gt nexus team issues type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@tfavorite
Copy link
Contributor

Describe the bug
When a flex toolbar has no overflowed items, only one button is focusable when the allowTabs setting is turned on.

To Reproduce
https://js-447mrh.stackblitz.io/
Code here: https://stackblitz.com/edit/js-447mrh?file=index.html

Steps to reproduce the behavior:
Attempt to tab through two buttons (Text button and Text button 2), only Text button 2 gets focused

Expected behavior
Both buttons should be focusable.

Version

  • ids-enterprise: 4.52.1

Platform

  • Infor Application/Team Name: Infor Nexus
  • OS Version: Mac OS X Catalina
  • Browser Name: Chrome
  • Browser Version: 91
@tmcconechy tmcconechy changed the title Issue tabbing through toolbar flex with allowTabs: true ToolbarFlex: Issue tabbing through with allowTabs: true Jul 1, 2021
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 team: gtn Gt nexus team issues labels Jul 1, 2021
@EdwardCoyle
Copy link
Contributor

To whoever picks this one up: Seems that the code setting tabIndex inside of the Flex Toolbar isn't respecting the allowTabs setting (which was added recently):

@EdwardCoyle EdwardCoyle added the focus: good first issue Good for for one of the first few issues label Jul 13, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.54.x (July 2021) Sprint via automation Jul 26, 2021
@Jah25 Jah25 moved this from To do to In progress in Enterprise 4.54.x (July 2021) Sprint Jul 26, 2021
@Jah25 Jah25 moved this from In progress to Ready for QA (beta) in Enterprise 4.54.x (July 2021) Sprint Jul 29, 2021
@janahintal
Copy link
Contributor

QA Passed. Thank you.
image
image

@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.54.x (July 2021) Sprint Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: good first issue Good for for one of the first few issues team: gtn Gt nexus team issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

No branches or pull requests

5 participants