Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar: Toolbar input missing on responsive/mobile view(454x823 below) #5388

Closed
nganotice opened this issue Jul 2, 2021 · 5 comments · Fixed by #6210
Closed

Toolbar: Toolbar input missing on responsive/mobile view(454x823 below) #5388

nganotice opened this issue Jul 2, 2021 · 5 comments · Fixed by #6210
Assignees
Labels
priority: trival Least important issues type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@nganotice
Copy link

Describe the bug
Toolbar input missing on responsive/mobile view(454x823 below)

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://main-enterprise.demo.design.infor.com/components/toolbar/example-toolbar-input.html
  2. See error

Expected behavior
Toolbar input should be responsive

Version
v4.53.0-dev

Screenshots
Responsive view(454x823 below)
Screen Shot 2021-07-02 at 4 07 33 PM

iPhone 12 Pro Max(actual device)
Screen Shot 2021-07-02 at 4 08 08 PM

Samsung Galaxy S20+(browserstack)
Screen Shot 2021-07-02 at 4 08 31 PM

Platform
Responsive view and mobile devices(454x823 below)

Additional context
N/A

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) priority: trival Least important issues type: bug 🐛 labels Jul 2, 2021
@EdwardCoyle
Copy link
Contributor

This one's a weird case because:

  • In this example specifically, the input field is not a Searchfield, by design.
  • The only items that will spill over to the Overflow menu are buttons and menu buttons. Inputs and Searchfields won't do this.
  • The input field is too big to fit alongside the other elements in this view, so it's hidden but not overflowed.

Ideally, someone wouldn't be using a regular input inside the Toolbar at all, opting for Searchfield instead, or moving this field somewhere outside the Toolbar. Maybe we should consider scrapping this example?

@tmcconechy
Copy link
Member

Yeah maybe simply move this over to a test? Im good with that for sure

@davidcarlsonberg davidcarlsonberg self-assigned this Mar 18, 2022
@tmcconechy tmcconechy added this to To do in Enterprise 4.62.x (Mar 2022) Sprint via automation Mar 21, 2022
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.62.x (Mar 2022) Sprint Mar 21, 2022
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.62.x (Mar 2022) Sprint Mar 23, 2022
@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.62.x (Mar 2022) Sprint Mar 23, 2022
@davidcarlsonberg
Copy link
Contributor

So make this a test file instead of an example file?

@tmcconechy
Copy link
Member

Yeah i was thinking that it could just be a test. But its ok now, not a big deal and this is done and closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: trival Least important issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants