Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message: Add close button option #5464

Closed
kwolentarski opened this issue Jul 27, 2021 · 2 comments · Fixed by #5526
Closed

Message: Add close button option #5464

kwolentarski opened this issue Jul 27, 2021 · 2 comments · Fixed by #5526
Assignees
Labels
type: enhancement ✨ [2] Velocity rating (Fibonacci)

Comments

@kwolentarski
Copy link

Is your feature request related to a problem or use case? Please describe.
Message component does not have an option to add close button as X (compared to Modal dialog or CAP).

Describe the solution you'd like
Message component should have the option to add close button (X) at the top. It could work as a third option in confirmation dialogs leaving some space for other buttons (important especially for localized text).
image

Describe alternatives you've considered
As a temporary solution we have added a third button, but there is not much space left for longer localizations
image

Additional context
Infor application: WFM

@tmcconechy tmcconechy transferred this issue from infor-design/enterprise-ng Jul 27, 2021
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: enhancement ✨ labels Jul 27, 2021
@tmcconechy
Copy link
Member

I think this makes sense. Since the modal has a close button option we could just add one to message and pass it through. Then check the styling.

But note this dialog is like a alert() dialog which does not have an X so your workaround seems like the actual correct UX.

@jbrcna
Copy link
Contributor

jbrcna commented Aug 20, 2021

this is now working as expected. moving this ticket to done. thanks
v4.55.0-dev
verified in https://main-enterprise.demo.design.infor.com/components/message/test-close-btn.html
image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.55.x (Aug 2021) Sprint Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants