Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAP: vertical tabs list scrolls with panel-container #5565

Closed
whernebrink opened this issue Aug 31, 2021 · 8 comments · Fixed by #5725 or #5816
Closed

CAP: vertical tabs list scrolls with panel-container #5565

whernebrink opened this issue Aug 31, 2021 · 8 comments · Fixed by #5725 or #5816
Assignees
Labels
team: m3 Issues for m3 and sub teams type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@whernebrink
Copy link

Describe the bug
When having vertical-tabs (which recently was added support for) in the CAP dialog, the tabs list scrolls together with the panel-container content.

To Reproduce

Steps to reproduce the behavior:

  1. https://stackblitz.com/edit/ids-quick-start-1030-ochbsp (I was unable to update the deps to 10.3 so it is on 9.5, but the issue is on latest enterprise-ng when running locally too).
  2. Click on button to trigger CAP dialog
  3. Scroll the content (if needed make your browser window small so the content don't fit)
  4. See the tabs list scrolling just like the panel container content does

Expected behavior
The tabs-list should have independent scrolling from the panel-container one.

Version
enterprise-ng 10.3.0

Screenshots
image

Platform

  • Infor Application/Team Name: Infor M3
  • OS Version: Big Sur
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) team: m3 Issues for m3 and sub teams type: bug 🐛 labels Aug 31, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Aug 31, 2021
@tmcconechy tmcconechy moved this from Triage to Ready For Dev in Enterprise (Next) Sprint Grooming Sep 10, 2021
@tmcconechy tmcconechy removed this from Ready For Dev in Enterprise (Next) Sprint Grooming Sep 29, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.57.x (Oct 2021) Sprint via automation Sep 29, 2021
@tjamesallen15
Copy link
Contributor

tjamesallen15 commented Oct 8, 2021

Hello @tmcconechy and @ericangeles ,

During my investigation yesterday, I happen to check that the div container inside has already a vertical scroll. Then I checked if it is implemented in angular, and was already there too.

Here is the video. I just happen to add two more paragraphs in the container to make it more visible. (Added in my localhost)
Angular Video: https://drive.google.com/file/d/1GXshe6Op9Ec1pG1xd4qcQvy1djrzUIqD/view?usp=sharing

@tmcconechy
Copy link
Member

Yes! @tjamesallen15 this looks like the right behavior. But also make sure that if you have a lot of items on the left side that that side can scroll too independently

@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.57.x (Oct 2021) Sprint Oct 11, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.57.x (Oct 2021) Sprint Oct 20, 2021
@janahintal
Copy link
Contributor

Hello, notice that in first load, the body scrolls independently but the scroll bar is not moving in the left side. When I click inside the tab and scroll, the scroll behavior changes and the body can't be scrolled again independently. As for the tabs, it now does have independent scrolling but not in main body.

IDS.Enterprise.-.Google.Chrome.2021-10-21.15-22-50.mp4

@tmcconechy tmcconechy moved this from Ready for QA (beta) to Failed QA (beta) in Enterprise 4.57.x (Oct 2021) Sprint Oct 21, 2021
@tmcconechy
Copy link
Member

Yes i see that. I think maybe there is an extra element with css overflow on it. I can reproduce it on https://main-enterprise.demo.design.infor.com/components/contextualactionpanel/example-cap-tabs-vertical-scroll.html by placing the mouse around the divider and scrolling then you see both move.

Take another look? @tjamesallen15 ?

@tmcconechy
Copy link
Member

@tjamesallen15 do you have another fix for this?

@tjamesallen15
Copy link
Contributor

@tjamesallen15 do you have another fix for this?

will check on this one.

@tjamesallen15
Copy link
Contributor

tjamesallen15 commented Nov 4, 2021

@janahintal i'll talk to you offline about this for further information

@tmcconechy tmcconechy moved this from Failed QA (beta) to Ready for QA (beta) in Enterprise 4.57.x (Oct 2021) Sprint Nov 4, 2021
@janahintal
Copy link
Contributor

@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.57.x (Oct 2021) Sprint Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: m3 Issues for m3 and sub teams type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
5 participants