Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cards: Mobile Enhancements and style changes #5609

Closed
3 tasks
tmcconechy opened this issue Sep 14, 2021 · 2 comments · Fixed by #5944
Closed
3 tasks

Cards: Mobile Enhancements and style changes #5609

tmcconechy opened this issue Sep 14, 2021 · 2 comments · Fixed by #5944
Assignees
Labels
focus: mobile Main focus is mobile improvements type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Sep 14, 2021

Describe the bug
Make some style changes to card exampes and make it work better on mobile. Based on Demo

https://main-enterprise.demo.design.infor.com/components/cards/example-variations-hitboxes.html

  • 16px spacing on sides

Fixes
https://www.figma.com/file/2pHthwwOhchvnpFXp69O7H/IDS-Card?node-id=229%3A10946

  • 16px spacing on sides on the card examples
  • for the main card example it should look close to this:
  • Change this in Web components too

MicrosoftTeams-image

**Additional context**

https://jira.infor.com/browse/UXD-2773

@tmcconechy tmcconechy added focus: mobile Main focus is mobile improvements type: bug 🐛 labels Sep 14, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Sep 14, 2021
@tmcconechy tmcconechy moved this from Triage to Check Back in Enterprise (Next) Sprint Grooming Sep 29, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.59.x (Dec 2021) Sprint via automation Nov 29, 2021
@ericangeles ericangeles self-assigned this Dec 2, 2021
@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.59.x (Dec 2021) Sprint Dec 13, 2021
@ericangeles ericangeles added the [2] Velocity rating (Fibonacci) label Dec 13, 2021
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.59.x (Dec 2021) Sprint Dec 14, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.59.x (Dec 2021) Sprint Dec 21, 2021
@janahintal
Copy link
Contributor

Hi @ericangeles, I'm getting different side spaces for scenario 1 & 2. Can you confirm if it is the margin left & right is the one I should be testing for the spaces? I got different spaces on each size for scenario 1 & 2. Thanks!

1.) Test the basic card

Go to http://localhost:4000/components/cards/example-index
Check the .card-header
It should have 16px spaces on both sides

Result:
Margin Left = 16px
Margin Right = 2px

image

2.) Test the card variations

Go to http://localhost:4000/components/cards/example-variations-hitboxes.html
Card variations should have 16px space on both sides

Result: 0px Margin left and Right
image

3.) Test the swipe action - Passed

Go to http://localhost:4000/components/swipe-action/example-index.html
Toggle the device toolbar in the chrome dev tool
swipe action right button should have 5px border-radius (top right, bottom right) see the Figma design
swipe action left button should have 5px border-radius (top left, bottom left) see the Figma design
Swipe action (left and right) should be wider than before. See the Figma design
Swipe action icon should be 16px x 16px
The contents of it should always be centered
The second line should be truncated

@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.59.x (Dec 2021) Sprint Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: mobile Main focus is mobile improvements type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants