Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swipe Container: Mobile Enhancements and style changes #5615

Closed
5 tasks
tmcconechy opened this issue Sep 15, 2021 · 2 comments · Fixed by #6077
Closed
5 tasks

Swipe Container: Mobile Enhancements and style changes #5615

tmcconechy opened this issue Sep 15, 2021 · 2 comments · Fixed by #6077
Assignees
@ericangeles
Labels
design Needs input from IDS Design Team type: enhancement ✨ [3] Velocity rating (Fibonacci)
Projects
Enterprise 4.60.x (Jan 2022) Sprint

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Sep 15, 2021 •
edited

Describe the bug
Make some style changes to swipe container examples and make it work better on mobile. Based on Demo
https://main-enterprise.demo.design.infor.com/components/swipe-action/example-index.html

Also make these changes in the web component version on a seperate PR.

Fixes
https://www.figma.com/file/2pHthwwOhchvnpFXp69O7H/IDS-Card?node-id=229%3A10946

  • 16px spacing on sides
  • show a new variant without icon
  • text box 87px width, overflows into a second line when it reaches the width max
  • No radius on the button when swiped
  • Make changes in WC too

Additional context
https://jira.infor.com/browse/UXD-3375
@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) type: enhancement ✨ labels Sep 15, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Sep 15, 2021
@tmcconechy tmcconechy added the design Needs input from IDS Design Team label Sep 29, 2021
@tmcconechy tmcconechy moved this from Triage to Check Back in Enterprise (Next) Sprint Grooming Sep 29, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.59.x (Dec 2021) Sprint via automation Nov 29, 2021
@ericangeles ericangeles self-assigned this Dec 2, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Dec 17, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.60.x (Jan 2022) Sprint via automation Jan 6, 2022
@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.60.x (Jan 2022) Sprint Jan 31, 2022
@ericangeles
Copy link
Contributor

@tmcconechy I believe some of these changes have been made, but I see an issue when the button left shouldn't have edges when swiped.

@ericangeles ericangeles mentioned this issue Jan 31, 2022
Merged
1 task
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.60.x (Jan 2022) Sprint Jan 31, 2022
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.60.x (Jan 2022) Sprint Feb 2, 2022
@tmcconechy tmcconechy moved this from Ready for QA (beta) to Done in Enterprise 4.60.x (Jan 2022) Sprint Feb 2, 2022
@CindyMercadoReyes
Copy link
Collaborator

BDD attached.
BDDStory_github5615.docx

@maezcruz maezcruz mentioned this issue Feb 17, 2022
Closed
This was referenced Feb 17, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericangeles ericangeles

Labels
design Needs input from IDS Design Team type: enhancement ✨ [3] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.60.x (Jan 2022) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5615 - Add mobile enhancements in Swipe Container infor-design/enterprise
3 participants
@tmcconechy @ericangeles @CindyMercadoReyes