Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FieldSet: Design Changes #5638

Closed
tmcconechy opened this issue Sep 22, 2021 · 6 comments · Fixed by #5908
Closed

FieldSet: Design Changes #5638

tmcconechy opened this issue Sep 22, 2021 · 6 comments · Fixed by #5908
Assignees
@davidcarlsonberg
Labels
focus: mobile Main focus is mobile improvements type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
Enterprise 4.59.x (Dec 2021) Sprint

Comments

@tmcconechy
Copy link
Member

Describe the bug
Changes to the Fieldset examples on https://main-enterprise.demo.design.infor.com/components/fieldset/example-index.html

Jira Ticket
https://jira.infor.com/browse/UXD-3450

For desktop too

  • Body 20 for title
  • text spans across all columns (mobile)
  • chart was using a green that doesn’t exist in our palate, changed it to emerald 07
  • adjusted spacing
  • aligned text with the vertical line label indicator (in chart)

Additional context
https://www.figma.com/file/pVS1Da3jV0C0lDhgoVE1GN/Fieldset?node-id=690%3A2905
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 labels Sep 22, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Sep 22, 2021
@tmcconechy tmcconechy added the focus: mobile Main focus is mobile improvements label Sep 29, 2021
@tmcconechy tmcconechy moved this from Triage to Ready For Dev in Enterprise (Next) Sprint Grooming Sep 29, 2021
@EdwardCoyle
Copy link
Contributor

@tmcconechy I think we need to open up permissions on that Figma file (can't see it)

@tmcconechy
Copy link
Member Author

@EdwardCoyle please ask @kevinwhitedesign for figma file access...

@davidcarlsonberg
Copy link
Contributor

Hey @tmcconechy and @EdwardCoyle I'm happy to take this one if no one else is on it?

@tmcconechy tmcconechy removed this from Ready For Dev in Enterprise (Next) Sprint Grooming Nov 4, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.58.x (Nov 2021) Sprint via automation Nov 4, 2021
@davidcarlsonberg davidcarlsonberg moved this from To do to In progress in Enterprise 4.58.x (Nov 2021) Sprint Nov 10, 2021
@davidcarlsonberg
Copy link
Contributor

@tmcconechy Looks like you've addressed the last three bullet points in the description? For the first two, is there a preferred method for addressing these issues? I'm not sure what text spans across all columns or Body 20 specifically refer to. Thanks!

@davidcarlsonberg davidcarlsonberg moved this from To do to In progress in Enterprise 4.59.x (Dec 2021) Sprint Nov 30, 2021
@davidcarlsonberg davidcarlsonberg mentioned this issue Nov 30, 2021
Merged
2 tasks
@tmcconechy
Copy link
Member Author

Some of it may be addressed @davidcarlsonberg if so just skip. But:

  • Body 20px in title means this fieldset title:

Screen Shot 2021-11-30 at 9 19 40 AM

  • The text spans across all columns - refers to the fact that the text will go to 100% (minus padding)

Screen Shot 2021-11-30 at 9 21 09 AM

@davidcarlsonberg davidcarlsonberg moved this from In progress to Pending Review in Enterprise 4.59.x (Dec 2021) Sprint Dec 7, 2021
@davidcarlsonberg davidcarlsonberg moved this from Pending Review to Ready for QA (beta) in Enterprise 4.59.x (Dec 2021) Sprint Dec 12, 2021
@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.59.x (Dec 2021) Sprint Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidcarlsonberg davidcarlsonberg

Labels
focus: mobile Main focus is mobile improvements type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.59.x (Dec 2021) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5638 - Fieldset Design Changes infor-design/enterprise
4 participants
@tmcconechy @EdwardCoyle @davidcarlsonberg @CindyMercadoReyes