-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datagrid: Add option to excel export to use the current locale #5663
Comments
When filing issues in the future please use the issue template https://github.com/infor-design/enterprise/issues/new/choose you could edit this issue to form into the markdown template for enhancements? But the question is clear. We do not automatically take the browsers locale as not everyone wants this. But you can easily read the browser locale and call I'm also not sure its a very good idea to change the export to use the locale. I would have to be convinced as this is a breaking change. And what we would be doing is formatting dates and numbers to strings. So it would make it difficult to use excel functions on the columns. I suggest that you just use the excel features to format the numbers and dates. Will keep this open for now tho for further discussion. |
Can i use Soho.Locale.set(navigator.language) i a MultiTenant environment? It's not possible to format the numbers to a german format in the App. So it's necessary to format it in excel. I think this isn't the way we should work with an CloudSuite. The enduser has to format it every time he uses the export function. |
I don't see why. The command just changed the Locale for the current browser instance. However as noted this isnt being used in the excel export. We can add an option for that however, but the problem is that dates and numbers will become strings to excel so will make it more challenging to use its own formatting features. But if thats what we want it could be an option. Changed the tile of the issue. |
Needs further investigation to determine if Locale or the CSV export is the culprit |
The problem is that it takes the unformatted data now. So would have to add an option that takes the data out of the table UI view instead. |
this is now working as expected. I'd just like to clarify if this is the correct behavior.
|
I've also noticed that after picking any locale from the dropdown - the link lands on http://localhost:4000/components/datagrid/example-export-format.html?locale=en-US |
It looks like the base URL sets statically. To fix this, you can use |
Also you can change the locale without reloading the page. I think you would just call
And then rerender() on the datagrid? Maybe thats better for a follow up fix? |
QA Failed. v4.59.0-dev |
This should be fixed on next deploy.... |
We'll do a retest again on this on next deploy. thanks @tmcconechy |
Its there now https://main-enterprise.demo.design.infor.com/components/datagrid/example-export-format.html and seems working @jbrcna |
Thanks @tmcconechy . this is what I see on my end. I might be missing something. there's no error in console the export functionality is working. however, there's a bit of a delay when changing locale using dropdown. Also the url/link is not changing. I assume that it should also change as well, but if it is by design, will mark this ticket Pass |
@yohannahbautista @jbrcna Yes i see something wierd in the example. If you change the locale say 3 times it always shows the previous locale not the one you just changed it to? A bit confusing so maybe we should fix that in the example too 👍🏻 |
BDD Attached. |
this is now working as expected. thank you! v4.59.0-dev |
What means Enterprise 4.59.x (Dec 2021) Sprint? When will this function be available? |
@NewCoffee1 this one is available in the current release: https://github.com/infor-design/enterprise/releases/tag/4.59.3 |
This means for MT customers it will be available after the february update? |
Sorry @NewCoffee1 i dont know what that means about Mt customers and Feb update.... All i can say is the fix was already released in Jan and should still be fixed in the upcoming monthly release |
Is your feature request related to a problem or use case? Please describe.
Hi IDS-Team,
While i'm working with the AppBuilder and the AppHub, i mentioned that the app doesn't take the locale from my browser (as every other application from the CloudSuite does). This is a bigger problem for the export function (to excel). Some formattings are not available (e.g. the Decimal separator (,) and 1000 separator (.) As usual in Germany) and have to be done after the excel export. When i set up different apps, i don't want the user to format the data after export.
Therefore i request you to improve your export functionality to take locale into consideration, so that after that the AppBuilder Team can implement a way for users to change the locale in app builder.
Right now the export function just takes the data from the grid with no formatting.
The best way would be that the application takes the locale from the browser or i can set it in the app configurations.
I explained the problem in ticket 15714463 on the Infor Concierge Portal.
Please work on this issue because it will increases the attractiveness of the app. Otherwise it becomes unusable in many cases.
Thanks
Describe the solution you'd like
Add an option so that the export to excel uses the current locale when exporting dates/numbers.
Describe alternatives you've considered
End user has to do it everytime which is a pain.
Additional context
AppBuilder and the AppHub
The text was updated successfully, but these errors were encountered: