Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge/Tag - Update colors for better accessibility contrast #5673

Closed
5 tasks
tmcconechy opened this issue Sep 28, 2021 · 10 comments · Fixed by #6010
Closed
5 tasks

Badge/Tag - Update colors for better accessibility contrast #5673

tmcconechy opened this issue Sep 28, 2021 · 10 comments · Fixed by #6010

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Sep 28, 2021

Describe the bug
Make some style changes to badge and tag colors.

Fixes
https://www.figma.com/file/gHmapzCfCqqPRv5RnFfGcE/?node-id=0%3A1

Additional context
https://jira.infor.com/browse/UXD-1865

@tmcconechy tmcconechy self-assigned this Sep 28, 2021
@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) type: enhancement ✨ labels Sep 28, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Sep 28, 2021
@tmcconechy tmcconechy moved this from Triage to Check Back in Enterprise (Next) Sprint Grooming Sep 29, 2021
@tmcconechy tmcconechy moved this from Check Back to Ready For Dev in Enterprise (Next) Sprint Grooming Nov 29, 2021
@tmcconechy tmcconechy removed this from Ready For Dev in Enterprise (Next) Sprint Grooming Nov 29, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.59.x (Dec 2021) Sprint via automation Nov 29, 2021
@tmcconechy tmcconechy removed their assignment Nov 29, 2021
@ericangeles ericangeles self-assigned this Dec 2, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Dec 20, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.60.x (Jan 2022) Sprint via automation Jan 6, 2022
@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.60.x (Jan 2022) Sprint Jan 11, 2022
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.60.x (Jan 2022) Sprint Jan 11, 2022
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.60.x (Jan 2022) Sprint Jan 14, 2022
@janahintal
Copy link
Contributor

QA Failed.
Light UI Expected color for Status 04 is #1F9254
Result: #1C7F49

Figma: https://www.figma.com/file/gHmapzCfCqqPRv5RnFfGcE/Q3-Accessibility-Tests
image

@janahintal janahintal moved this from Ready for QA (beta) to Failed QA (beta) in Enterprise 4.60.x (Jan 2022) Sprint Jan 17, 2022
@ericangeles
Copy link
Contributor

@janahintal can you please provide the steps for this test? Thanks.

@ericangeles
Copy link
Contributor

@tmcconechy @kevinwhitedesign can we confirm the color that we should use for the New Light? In the example page, we used emerald09 (#1C7F49) but in the Figma file it's #1F9254 (emerald08).

@ericangeles ericangeles moved this from Failed QA (beta) to Pending Review in Enterprise 4.60.x (Jan 2022) Sprint Jan 17, 2022
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.60.x (Jan 2022) Sprint Jan 18, 2022
@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.60.x (Jan 2022) Sprint Jan 20, 2022
@tmcconechy tmcconechy reopened this Feb 10, 2022
Enterprise 4.60.x (Jan 2022) Sprint automation moved this from Done to To do Feb 10, 2022
@tmcconechy
Copy link
Member Author

I will reverse some of these changes for now due to #6114
The reason being the size and font changes look abrupt and out of place and want to avoid complaints and breaking.

The biggest problem being the size change on the fields that will look out of place on forms with different fields
Screen Shot 2022-02-10 at 2 38 29 PM

And the tag size changes in general can cause disruption. So will kick this back for now

Approved with @inforandy

@kevinwhitedesign
Copy link

I believe reverting from this change will end in failing accessibility latest WCAG guidelines. Correct me if I'm wrong @elizabethhartley

@tmcconechy
Copy link
Member Author

tmcconechy commented Feb 11, 2022

So according to a scan on https://4580-enterprise.demo.design.infor.com/components/tag/example-index.html only one thing fails...

New Light:

  • only the orange alert tag fails -> can easier be fixed by using a lighter alert color

So rather easy to just change one color then change the size of the tags and multiselect and make the multiselect look different on forms. Just has too much impact for this change but will keep it in the backlog for later.

@kevinwhitedesign
Copy link

@tmcconechy oh right, we decided to make them all bold for consistency. @elizabethhartley reminded me

@tmcconechy
Copy link
Member Author

Yeah i think in this case we should come back to this one and just have:

  • check the 3 themes
  • only change the background colors up and down
  • change the text color between white or slate 100 depending which bg color
  • not change any sizes

Also wondering about yellow or orange alerts - which is most often done

@stale
Copy link

stale bot commented Mar 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 8, 2023
@tmcconechy tmcconechy added stale Marked as 360 days old. Will close if not needed. and removed wontfix labels Mar 8, 2023
@stale stale bot removed the stale Marked as 360 days old. Will close if not needed. label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants