-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Badge/Tag - Update colors for better accessibility contrast #5673
Comments
QA Failed. Figma: https://www.figma.com/file/gHmapzCfCqqPRv5RnFfGcE/Q3-Accessibility-Tests |
@janahintal can you please provide the steps for this test? Thanks. |
@tmcconechy @kevinwhitedesign can we confirm the color that we should use for the New Light? In the example page, we used emerald09 (#1C7F49) but in the Figma file it's #1F9254 (emerald08). |
This issue is now resolved. |
I will reverse some of these changes for now due to #6114 The biggest problem being the size change on the fields that will look out of place on forms with different fields And the tag size changes in general can cause disruption. So will kick this back for now Approved with @inforandy |
I believe reverting from this change will end in failing accessibility latest WCAG guidelines. Correct me if I'm wrong @elizabethhartley |
So according to a scan on https://4580-enterprise.demo.design.infor.com/components/tag/example-index.html only one thing fails... New Light:
So rather easy to just change one color then change the size of the tags and multiselect and make the multiselect look different on forms. Just has too much impact for this change but will keep it in the backlog for later. |
@tmcconechy oh right, we decided to make them all bold for consistency. @elizabethhartley reminded me |
Yeah i think in this case we should come back to this one and just have:
Also wondering about yellow or orange alerts - which is most often done |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Describe the bug
Make some style changes to badge and tag colors.
Fixes
https://www.figma.com/file/gHmapzCfCqqPRv5RnFfGcE/?node-id=0%3A1
Additional context
https://jira.infor.com/browse/UXD-1865
The text was updated successfully, but these errors were encountered: