Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid:Row selection using keyboard up and down arrows #5713

Closed
jonathanamiran opened this issue Oct 6, 2021 · 4 comments · Fixed by #5933
Closed

Datagrid:Row selection using keyboard up and down arrows #5713

jonathanamiran opened this issue Oct 6, 2021 · 4 comments · Fixed by #5933
Assignees
Labels
team: m3 Issues for m3 and sub teams type: enhancement ✨ [2] Velocity rating (Fibonacci)

Comments

@jonathanamiran
Copy link

Is your feature request related to a problem or use case? Please describe.
I couldn't find this feature in Data Grid

Describe the solution you'd like
In Single select mode we want to be able to select the next row by clicking the Down arrow on the keyboard, and the previous row by clicking the Up arrow.
(We had this feature in Infor M3 IBrix table)

Describe alternatives you've considered
I've made a workaround using activecellchange event that will select the new row - but I must check that it was a different row, otherwise it will be infinite loop.

Additional context
https://jsfiddle.net/sebulbajoe/taxy5hs6/4/show
datagrid-keyboard-selection

Thanks!

@tmcconechy
Copy link
Member

Maybe you could also use the https://github.com/infor-design/enterprise/blob/main/src/components/datagrid/datagrid.js#L238 callback and on up or down arrow get the selected row and call the prev/next one.

I'm not seeing any issue in what you did though? Are you basically asking for a setting for this?

@jonathanamiran
Copy link
Author

I tried using onKeyDown callback, but it has some limitations - like all other keyboard events are disabled, for instance, clicking F5 to refresh the screen does nothing, I need to focus on something else on the screen to make it work again.

My "workaround" doesn't deal with disabled rows, paging, etc.
Also it would be nice to have it as a setting that can be toggled (like clickToSelect)

Thanks

@tmcconechy tmcconechy added team: m3 Issues for m3 and sub teams and removed type: support 🆘 labels Oct 6, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Oct 6, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.59.x (Dec 2021) Sprint via automation Nov 29, 2021
@tjamesallen15 tjamesallen15 moved this from To do to In progress in Enterprise 4.59.x (Dec 2021) Sprint Dec 7, 2021
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.59.x (Dec 2021) Sprint Dec 10, 2021
@CindyMercadoReyes
Copy link
Collaborator

BDD attached.
BDDStory_github5713.docx

@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.59.x (Dec 2021) Sprint Dec 17, 2021
@nganotice
Copy link

This has been QA tested and passed on v4.59.0-dev.

https://main-enterprise.demo.design.infor.com/components/datagrid/example-key-row-select.html

Video 24

Moving this ticket to Done.

Thanks!

@nganotice nganotice moved this from Ready for QA (beta) to Done in Enterprise 4.59.x (Dec 2021) Sprint Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: m3 Issues for m3 and sub teams type: enhancement ✨ [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants